Last Comment Bug 691184 - Don't throw on setting ctx.textAlign, ctx.textBaseline
: Don't throw on setting ctx.textAlign, ctx.textBaseline
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: 2D (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Ed Morley [:emorley]
:
Mentors:
http://www.whatwg.org/html/#dom-conte...
Depends on:
Blocks: 622842
  Show dependency treegraph
 
Reported: 2011-10-02 12:40 PDT by :Ms2ger
Modified: 2011-10-07 12:45 PDT (History)
3 users (show)
emorley: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (5.28 KB, patch)
2011-10-06 10:37 PDT, Ed Morley [:emorley]
no flags Details | Diff | Splinter Review
Tests (4.23 KB, patch)
2011-10-06 11:01 PDT, :Ms2ger
bugs: review+
Details | Diff | Splinter Review
Patch v1 (minus tests) (3.47 KB, patch)
2011-10-06 16:16 PDT, Ed Morley [:emorley]
bugs: review+
Details | Diff | Splinter Review

Comment 1 :Ms2ger 2011-10-02 12:53:12 PDT
I'll fix it, unless you'd like to... I've got the tests locally.
Comment 2 Ed Morley [:emorley] 2011-10-06 10:37:20 PDT
Created attachment 565276 [details] [diff] [review]
Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=b3000af72f01
Comment 3 :Ms2ger 2011-10-06 11:01:29 PDT
Created attachment 565286 [details] [diff] [review]
Tests

Tests I promised.
Comment 4 Ed Morley [:emorley] 2011-10-06 11:09:11 PDT
Ah sorry I thought you meant you had the Philip Taylor tests locally, rather than an updated test_canvas.html. Thanks!
Comment 5 :Ms2ger 2011-10-06 14:03:53 PDT
No problem, I should have expressed myself more clearly. (I've been working on updating these tests, and I'd rather get closer to my expected end-result than farther away from it :).)
Comment 6 Ed Morley [:emorley] 2011-10-06 16:16:05 PDT
Created attachment 565389 [details] [diff] [review]
Patch v1 (minus tests)

https://tbpl.mozilla.org/?tree=Try&rev=19fdc5b8499f

(with Ms2ger's test changeset this time)
Comment 7 Ed Morley [:emorley] 2011-10-06 16:44:25 PDT
(In reply to Ms2ger from comment #5)
> No problem, I should have expressed myself more clearly. (I've been working
> on updating these tests, and I'd rather get closer to my expected end-result
> than farther away from it :).)

Well it meant I finally ventured into the world of Mochitests for the first time (yeah long overdue!) in creating the v1 patch, so was fairly constructive regardless :-)
Comment 8 Olli Pettay [:smaug] 2011-10-07 01:53:51 PDT
Comment on attachment 565389 [details] [diff] [review]
Patch v1 (minus tests)

The spec is bad, but I don't care enough to complain.

Note You need to log in before you can comment on or make changes to this bug.