Don't throw on setting ctx.textAlign, ctx.textBaseline

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: 2D
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Tested by

http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.text.align.invalid.html
http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.text.baseline.invalid.html
(Reporter)

Comment 1

6 years ago
I'll fix it, unless you'd like to... I've got the tests locally.
(Assignee)

Updated

6 years ago
Summary: Don't throw on setting cx.textAlign, cx.textBaseline → Don't throw on setting ctx.textAlign, ctx.textBaseline
(Assignee)

Comment 2

6 years ago
Created attachment 565276 [details] [diff] [review]
Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=b3000af72f01
Assignee: Ms2ger → bmo
(Reporter)

Comment 3

6 years ago
Created attachment 565286 [details] [diff] [review]
Tests

Tests I promised.
(Assignee)

Comment 4

6 years ago
Ah sorry I thought you meant you had the Philip Taylor tests locally, rather than an updated test_canvas.html. Thanks!
(Reporter)

Comment 5

6 years ago
No problem, I should have expressed myself more clearly. (I've been working on updating these tests, and I'd rather get closer to my expected end-result than farther away from it :).)
(Assignee)

Comment 6

6 years ago
Created attachment 565389 [details] [diff] [review]
Patch v1 (minus tests)

https://tbpl.mozilla.org/?tree=Try&rev=19fdc5b8499f

(with Ms2ger's test changeset this time)
Attachment #565276 - Attachment is obsolete: true
Attachment #565389 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

6 years ago
Attachment #565286 - Flags: review?(Olli.Pettay)
(Assignee)

Comment 7

6 years ago
(In reply to Ms2ger from comment #5)
> No problem, I should have expressed myself more clearly. (I've been working
> on updating these tests, and I'd rather get closer to my expected end-result
> than farther away from it :).)

Well it meant I finally ventured into the world of Mochitests for the first time (yeah long overdue!) in creating the v1 patch, so was fairly constructive regardless :-)

Comment 8

6 years ago
Comment on attachment 565389 [details] [diff] [review]
Patch v1 (minus tests)

The spec is bad, but I don't care enough to complain.
Attachment #565389 - Flags: review?(Olli.Pettay) → review+

Updated

6 years ago
Attachment #565286 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 9

6 years ago
Thanks for the fast review :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5c6d21109da
https://hg.mozilla.org/integration/mozilla-inbound/rev/45249d949463
Flags: in-testsuite+
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/d5c6d21109da
https://hg.mozilla.org/mozilla-central/rev/45249d949463
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.