Closed Bug 691184 Opened 10 years ago Closed 10 years ago
Don't throw on setting ctx
.text Align, ctx .text Baseline
I'll fix it, unless you'd like to... I've got the tests locally.
Summary: Don't throw on setting cx.textAlign, cx.textBaseline → Don't throw on setting ctx.textAlign, ctx.textBaseline
Assignee: Ms2ger → bmo
Tests I promised.
Ah sorry I thought you meant you had the Philip Taylor tests locally, rather than an updated test_canvas.html. Thanks!
No problem, I should have expressed myself more clearly. (I've been working on updating these tests, and I'd rather get closer to my expected end-result than farther away from it :).)
https://tbpl.mozilla.org/?tree=Try&rev=19fdc5b8499f (with Ms2ger's test changeset this time)
Attachment #565286 - Flags: review?(Olli.Pettay)
(In reply to Ms2ger from comment #5) > No problem, I should have expressed myself more clearly. (I've been working > on updating these tests, and I'd rather get closer to my expected end-result > than farther away from it :).) Well it meant I finally ventured into the world of Mochitests for the first time (yeah long overdue!) in creating the v1 patch, so was fairly constructive regardless :-)
Comment on attachment 565389 [details] [diff] [review] Patch v1 (minus tests) The spec is bad, but I don't care enough to complain.
Attachment #565389 - Flags: review?(Olli.Pettay) → review+
Attachment #565286 - Flags: review?(Olli.Pettay) → review+
Thanks for the fast review :-) https://hg.mozilla.org/integration/mozilla-inbound/rev/d5c6d21109da https://hg.mozilla.org/integration/mozilla-inbound/rev/45249d949463
Target Milestone: --- → mozilla10
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.