691184 - Don't throw on setting ctx.textAlign, ctx.textBaseline

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Tested by

http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.text.align.invalid.html
http://www.w3c-test.org/html/tests/submission/PhilipTaylor/canvas/2d.text.baseline.invalid.html

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'll fix it, unless you'd like to... I've got the tests locally.

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

https://tbpl.mozilla.org/?tree=Try&rev=b3000af72f01

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Tests

Tests I promised.

Comment 4

[Ed Morley [:emorley]]

Ah sorry I thought you meant you had the Philip Taylor tests locally, rather than an updated test_canvas.html. Thanks!

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No problem, I should have expressed myself more clearly. (I've been working on updating these tests, and I'd rather get closer to my expected end-result than farther away from it :).)

Comment 6

[Ed Morley [:emorley]]

Attachment: Patch v1 (minus tests)

https://tbpl.mozilla.org/?tree=Try&rev=19fdc5b8499f

(with Ms2ger's test changeset this time)

Comment 7

[Ed Morley [:emorley]]

(In reply to Ms2ger from comment #5)
> No problem, I should have expressed myself more clearly. (I've been working
> on updating these tests, and I'd rather get closer to my expected end-result
> than farther away from it :).)

Well it meant I finally ventured into the world of Mochitests for the first time (yeah long overdue!) in creating the v1 patch, so was fairly constructive regardless :-)

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 565389 [details] [diff] [review]
Patch v1 (minus tests)

The spec is bad, but I don't care enough to complain.

Comment 9

[Ed Morley [:emorley]]

Thanks for the fast review :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5c6d21109da
https://hg.mozilla.org/integration/mozilla-inbound/rev/45249d949463

Comment 10

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/d5c6d21109da
https://hg.mozilla.org/mozilla-central/rev/45249d949463