As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 691431 - Firefox 10.0a1 Crash Report [@ WrapPreserve3DList ]
: Firefox 10.0a1 Crash Report [@ WrapPreserve3DList ]
: crash, regression, reproducible
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- critical (vote)
: mozilla10
Assigned To: Nobody; OK to take it and work on it
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2011-10-03 11:34 PDT by Marcia Knous [:marcia - use ni]
Modified: 2011-10-18 13:23 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Remove invalid assertion and add NULL check (1.21 KB, patch)
2011-10-03 15:15 PDT, Matt Woodrow (:mattwoodrow)
roc: review+
Details | Diff | Splinter Review

Description User image Marcia Knous [:marcia - use ni] 2011-10-03 11:34:46 PDT
Seen while looking at trunk crash stats. - crashes started showing up in crash stats using the 20111001 build.

Possible pushlog regression range: is mentioned twice in the comments.

Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	WrapPreserve3DList 	layout/generic/nsFrame.cpp:1528
1 	xul.dll 	WrapPreserve3DList 	layout/generic/nsFrame.cpp:1540
2 	xul.dll 	nsIFrame::BuildDisplayListForStackingContext 	
3 	xul.dll 	nsWindowSH::NewResolve 	dom/base/nsDOMClassInfo.cpp:6483
4 	xul.dll 	SelectorMatchesTree 	layout/style/nsCSSRuleProcessor.cpp:2135
5 	xul.dll 	PL_DHashTableOperate 	obj-firefox/xpcom/build/pldhash.cpp:622
6 	xul.dll 	ApplyOverflowClipping 	layout/generic/nsFrame.cpp:1358
7 	xul.dll 	nsIFrame::BuildDisplayListForChild 	layout/generic/nsFrame.cpp:1923
Comment 1 User image Marcia Knous [:marcia - use ni] 2011-10-03 12:43:46 PDT
I can reproduce this by loading
Comment 2 User image Marcia Knous [:marcia - use ni] 2011-10-03 15:08:45 PDT
Adding the Mac specific signature.
Comment 3 User image Naoki Hirata :nhirata (please use needinfo instead of cc) 2011-10-03 15:15:22 PDT
Android crashes as well.  I can crash on the site as well by going to the URL and then clicking on the unsupported site link.
Same crash signature as on Mac : [@ WrapPreserve3DListInternal ]
Comment 4 User image Matt Woodrow (:mattwoodrow) 2011-10-03 15:15:45 PDT
Created attachment 564349 [details] [diff] [review]
Remove invalid assertion and add NULL check

This assertion was invalid, and we need to null check that the item has a frame.
Comment 5 User image Matt Woodrow (:mattwoodrow) 2011-10-03 15:29:05 PDT
Not that this patch still doesn't make the site look completely correct.

The site is using -moz-perspective:1000; (no px) which we parse as invalid, as per the spec. Webkit accepts persective numbers and treats them as pixels.
Comment 6 User image Matt Woodrow (:mattwoodrow) 2011-10-03 18:27:18 PDT
Comment 7 User image Marco Bonardo [::mak] 2011-10-04 02:08:33 PDT
Comment 8 User image Marcia Knous [:marcia - use ni] 2011-10-18 13:23:43 PDT
Verified fixed using Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:10.0a1) Gecko/20111018 Firefox/10.0a1. I checked the latest Mac nightly as well and no crash there.

Note You need to log in before you can comment on or make changes to this bug.