691478 - JavaScript strict warning: resource:///modules/HUDService.jsm, line 5012: reference to undefined property this.lastInputValue

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Richard Newman [:rnewman]]

Strict mode warning dumped to stdout.

JavaScript strict warning: resource:///modules/HUDService.jsm, line 5012: reference to undefined property this.lastInputValue

Comment 1

[Dave Camp (:dcamp)]

We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I am not able to reproduce this. Richard, what do we need to do to reproduce this bug?

Comment 3

[Richard Newman [:rnewman]]

(In reply to Michael Ratcliffe from comment #2)
> I am not able to reproduce this. Richard, what do we need to do to reproduce
> this bug?

As I recall, this was just launching an m-c build with a testing profile. I periodically scan through the console output and file bugs for all the warnings and errors I find.

I can't reproduce this bug in a current build, but that doesn't mean it isn't still lurking. I assume this is the culprit:

  http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/HUDService.jsm#5174

A little bit of code reading might reveal a timing bug here.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Ridiculously simple patch

Ridiculously simple patch.

inputEventHandler() could theoretically be called before setInputValue(). Defining this.lastInputValue as "" fixes this.

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/93e89c2fd096

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/93e89c2fd096