Closed Bug 691478 Opened 8 years ago Closed 8 years ago

JavaScript strict warning: resource:///modules/HUDService.jsm, line 5012: reference to undefined property this.lastInputValue

Categories

(DevTools :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: rnewman, Assigned: miker)

Details

Attachments

(1 file)

Strict mode warning dumped to stdout.

JavaScript strict warning: resource:///modules/HUDService.jsm, line 5012: reference to undefined property this.lastInputValue
We're doing developer tool prioritization, filter on 'brontozaur'
to ignore the spam.
Priority: -- → P2
I am not able to reproduce this. Richard, what do we need to do to reproduce this bug?
(In reply to Michael Ratcliffe from comment #2)
> I am not able to reproduce this. Richard, what do we need to do to reproduce
> this bug?

As I recall, this was just launching an m-c build with a testing profile. I periodically scan through the console output and file bugs for all the warnings and errors I find.

I can't reproduce this bug in a current build, but that doesn't mean it isn't still lurking. I assume this is the culprit:

  http://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/HUDService.jsm#5174

A little bit of code reading might reveal a timing bug here.
Ridiculously simple patch.

inputEventHandler() could theoretically be called before setInputValue(). Defining this.lastInputValue as "" fixes this.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Attachment #583429 - Flags: review?(dcamp)
Whiteboard: [has-patch]
Attachment #583429 - Flags: review?(dcamp) → review+
Whiteboard: [has-patch] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/93e89c2fd096
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/93e89c2fd096
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.