Closed
Bug 691721
Opened 14 years ago
Closed 14 years ago
Potential memory leak in DevTools test
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 10
People
(Reporter: miker, Assigned: miker)
Details
(Whiteboard: [styleinspector][fixed-in-fx-team])
Attachments
(1 file)
|
1.01 KB,
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
In browser/devtools/styleinspector/test/browser/browser_bug683672.js we add an event listener:
browser.addEventListener("load", tabLoaded, true);
It is never removed and could potentially cause a memory leak (not sure how the test passes). This was copied from other tests so we should go through at least all of out DevTools tests and ensure that the listener is removed.
|
Assignee | |
Comment 1•14 years ago
|
||
Only one test had that issue.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Attachment #564514 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Updated•14 years ago
|
Summary: Potential memory leak in a number of DevTools tests → Potential memory leak in DevTools test
|
||
Comment 2•14 years ago
|
||
Comment on attachment 564514 [details] [diff] [review]
Potential Memory Leak Patch
Review of attachment 564514 [details] [diff] [review]:
-----------------------------------------------------------------
Patch looks good. Thanks!
Attachment #564514 -
Flags: review?(mihai.sucan) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: [styleinspector][land-in-fx-team]
|
||
Comment 3•14 years ago
|
||
Whiteboard: [styleinspector][land-in-fx-team] → [styleinspector][fixed-in-fx-team]
|
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•