Potential memory leak in DevTools test

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: miker, Assigned: miker)

Tracking

unspecified
Firefox 10
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [styleinspector][fixed-in-fx-team])

Attachments

(1 attachment)

In browser/devtools/styleinspector/test/browser/browser_bug683672.js we add an event listener:
browser.addEventListener("load", tabLoaded, true);

It is never removed and could potentially cause a memory leak (not sure how the test passes). This was copied from other tests so we should go through at least all of out DevTools tests and ensure that the listener is removed.
Created attachment 564514 [details] [diff] [review]
Potential Memory Leak Patch

Only one test had that issue.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Attachment #564514 - Flags: review?(mihai.sucan)
Summary: Potential memory leak in a number of DevTools tests → Potential memory leak in DevTools test
Comment on attachment 564514 [details] [diff] [review]
Potential Memory Leak Patch

Review of attachment 564514 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good. Thanks!
Attachment #564514 - Flags: review?(mihai.sucan) → review+

Updated

6 years ago
Whiteboard: [styleinspector][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/43611c125310
Whiteboard: [styleinspector][land-in-fx-team] → [styleinspector][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/43611c125310
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.