Last Comment Bug 691801 - nsPluginNativeWindowWin.cpp: 'return' : truncation from 'nsresult' to 'bool'
: nsPluginNativeWindowWin.cpp: 'return' : truncation from 'nsresult' to 'bool'
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla13
Assigned To: Jim Mathies [:jimm]
:
: Benjamin Smedberg [:bsmedberg]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-04 09:31 PDT by Jim Mathies [:jimm]
Modified: 2012-02-09 10:32 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.10 KB, patch)
2012-01-20 10:46 PST, Jim Mathies [:jimm]
jaas: review+
Details | Diff | Splinter Review

Description Jim Mathies [:jimm] 2011-10-04 09:31:24 PDT
http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsPluginNativeWindowWin.cpp#178

e:/builds/moz2_slave/try-w32/build/dom/plugins/base/nsPluginNativeWindowWin.cpp(181) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'
e:/builds/moz2_slave/try-w32/build/dom/plugins/base/nsPluginNativeWindowWin.cpp(182) : warning C4305: 'return' : truncation from 'nsresult' to 'bool'

Poking through a build dump on another bug and noticed these.
Comment 1 Jim Mathies [:jimm] 2012-01-20 10:46:13 PST
Created attachment 590253 [details] [diff] [review]
patch

Cleans up these warnings plus some others.
Comment 3 Ed Morley [:emorley] 2012-02-09 10:32:42 PST
https://hg.mozilla.org/mozilla-central/rev/874062cc7df7

Note You need to log in before you can comment on or make changes to this bug.