691895 - remove bit.ly

Status: RESOLVED FIXED

(Mozilla Labs :: F1, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Since twitter shortens urls, we don't need bit.ly, lets remove it for now and consider adding it back when we can apify the shortening.

Comment 1

[Shane Caraveo (:mixedpuppy)]

hmm, I just tried sharing a long url with bitly disabled, and I get the "over 140 characters" error from twitter.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

I can't reproduce the problem (ie, I can share long links just fine).  Of note:

* The code that would call bitly is effectivly disabled.  index.js is asking store.js for an item named 'shortenPrefs' and no such item is ever setup by our code.  So I'm not sure what you mean by "with bitly disabled"?

* The console shows the long URL being sent to twitter - ie, I'm pretty sure we are not currently using bitly to pre-shorten.  I just shared a total of 148 chars to twitter and the console shows:

status=this%20is%20very%20long%21%20http%3A%2F%2Flifehacker.com%2F5849050%2Ftake-an-online-driving-
ourse-to-save-up-to-10-on-auto-insurance-or-reduce-points-from-your-record
info: send was success

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: remove bitly code

Comment 4

[Shane Caraveo (:mixedpuppy)]

pushed https://github.com/mozilla/fx-share-addon/commit/c2148ca1abe66a50f466935f7157db927fbd6ab8