Closed Bug 691912 Opened 13 years ago Closed 13 years ago

Please add 'libstdc\+\+\.so@.* libc.so@.*' to the skiplist as irrelevantSignatureRegEx

Categories

(Socorro :: General, task)

Product:
Socorro
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nhirata, Assigned: laura)

Details

Please add: 'libstdc\+\+\.so@.*' 'libc.so@.*' to the skiplist as irrelevantSignatureRegEx Trying to clean up reports like : https://crash-stats.mozilla.com/report/index/f8ce0bd7-25f6-44fc-bbf2-f99d32111001 to ignore the first 4 frames. "0 libc.so abort 1 libc.so dlfree 2 libc.so free 3 libstdc++.so _ZdaPvRKSt9nothrow_t"
That's not going to work. The way signature generation works currently, the skiplist applies to whatever the signature for that particular stack frame would be. If there's a function name, then that is used. If there are no symbols, then you get the libc.so@0x... In this case, you want abort, dlfree, free and _ZdaPvRKSt9nothrow_t on the skiplist. (I suspect some of those are already on it.)
libc.so@.* is already in this list, but of course what comment #1 says applies here. Please redefine what you need to be ignored or prepended based on that. Note that we intentionally prepend things like that in many cases.
ok, so based on Comment 1 and 2, then we should put these ignore list for the prepend for "abort", "dlfree", "free", and "_ZdaPvRKSt9nothrow_t\"" Is that right?
'free' and 'dlfree' are already on the prefix list in this form: '.*free' That leaves 'abort' and '_ZdaPvRKSt9nothrow_t\"'. I'm not clear, do you want these ignored or prepended?
Assignee: nobody → laura
Target Milestone: --- → 2.3
'abort' should go on the prefix list as well - there are already some items ending with abort there, right? Makes me wonder if .*abort would be a good idea there as well. For '_ZdaPvRKSt9nothrow_t\"' I'm completely unsure how stable that symbol name even is between versions of libstdc++ and would like the input of someone who knows about c++ library stuff.
That's just a mangled C++ symbol, it demangles to "operator delete[](void*, std::nothrow_t const&)" (I'm not sure why it's not demangled in the symbol files, maybe some failure on Breakpad's part.)
Is it going to be consistently mangled?
Yes, C++ name mangling is part of the ABI, and doesn't change.
Commit pushed to https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/f8f2a318cd9870838b1dc2a2dee34ca8544ebfd1 Merge pull request #59 from lauraxt/2.3skiplist Skiplist changes for bug 691912:
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.