GCC 4.6 build warning: "nsCSSFrameConstructor.cpp:9934:8: warning: variable 'done' set but not used [-Wunused-but-set-variable]"

RESOLVED FIXED in mozilla10

Status

()

Core
Layout: Text
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Filing bug on this GCC 4.6 build warning (the only one I get for nsCSSFrameConstructor.cpp):
> nsCSSFrameConstructor.cpp: In function 'PRInt32 FirstLetterCount(const nsTextFragment*)':
> nsCSSFrameConstructor.cpp:9934:8: warning: variable 'done' set but not used [-Wunused-but-set-variable]

This variable was added in April 1999 in this CVS commit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/base&command=DIFF_FRAMESET&file=nsCSSFrameConstructor.cpp&rev2=1.104&rev1=1.103
with only one use:
> while (aNumFragments && !done) {

That one use was subsequently removed in this commit, in Oct 1999:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/base&command=DIFF_FRAMESET&file=nsCSSFrameConstructor.cpp&rev2=1.268&rev1=1.267

and this variable appears to have been unused since then.
Blocks: 187528
Created attachment 564694 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #564694 - Flags: review?(dbaron)
Comment on attachment 564694 [details] [diff] [review]
fix

r=dbaron
Attachment #564694 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d323beedf560
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/d323beedf560
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.