691959 - GCC 4.6 build warning: "nsCSSFrameConstructor.cpp:9934:8: warning: variable 'done' set but not used [-Wunused-but-set-variable]"

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this GCC 4.6 build warning (the only one I get for nsCSSFrameConstructor.cpp):
> nsCSSFrameConstructor.cpp: In function 'PRInt32 FirstLetterCount(const nsTextFragment*)':
> nsCSSFrameConstructor.cpp:9934:8: warning: variable 'done' set but not used [-Wunused-but-set-variable]

This variable was added in April 1999 in this CVS commit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/base&command=DIFF_FRAMESET&file=nsCSSFrameConstructor.cpp&rev2=1.104&rev1=1.103
with only one use:
> while (aNumFragments && !done) {

That one use was subsequently removed in this commit, in Oct 1999:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/base&command=DIFF_FRAMESET&file=nsCSSFrameConstructor.cpp&rev2=1.268&rev1=1.267

and this variable appears to have been unused since then.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 564694 [details] [diff] [review]
fix

r=dbaron

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d323beedf560

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d323beedf560