691992 - Fully split up {g,s}etAttributes into property/element/special/generic forms

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

This is pretty dreary, but it'll help with splitting up the work to split property representation into elements and non-elements, so on we go.

Comment 1

[Brian Hackett [Laid off!]]

Comment on attachment 564718 [details] [diff] [review]
Patch

General comment:

It seems weird for Classes to have hooks for both generic accesses and specific kinds of accesses (e.g. array_getGenericAttributes vs. array_getPropertyAttributes), especially when they either duplicate functionality or defer to one another in a hand-rolled way (e.g. proxy_SetPropertyAttributes).  This seems unnecessarily verbose; could either the generic or the specialized methods be removed from Class?  My preference would be to remove the latter and just have the generic form, as then the Class interface would be largely unchanged from before property splitting (right?).

Comment 2

[Jeff Walden [:Waldo]]

(missed the review mail originally, wonder how many other of these I missed... :-\ )

The generic interfaces will go away eventually, and the specialized ones will be all that remain.  It's just easier, for now, to leave the generic versions in place so as not to have to invasively touch quite as many users, especially when some of those users will go away completely when the property-element split happens.

Comment 3

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a848c512af7

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5a848c512af7