Last Comment Bug 692069 - Shove regexp backend-specific stuff behind a comprehensible interface
: Shove regexp backend-specific stuff behind a comprehensible interface
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Chris Leary [:cdleary] (not checking bugmail)
:
Mentors:
Depends on: 691695
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-05 04:18 PDT by Chris Leary [:cdleary] (not checking bugmail)
Modified: 2011-10-13 22:33 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Factor out interface for backend-dependent gunk, add comments. (17.85 KB, patch)
2011-10-05 04:18 PDT, Chris Leary [:cdleary] (not checking bugmail)
no flags Details | Diff | Splinter Review
Factor out interface for backend-dependent gunk, add comments. (17.85 KB, patch)
2011-10-05 04:23 PDT, Chris Leary [:cdleary] (not checking bugmail)
luke: review+
Details | Diff | Splinter Review

Description Chris Leary [:cdleary] (not checking bugmail) 2011-10-05 04:18:37 PDT
Created attachment 564790 [details] [diff] [review]
Factor out interface for backend-dependent gunk, add comments.

Depends on patch in bug 691695.
Comment 1 Chris Leary [:cdleary] (not checking bugmail) 2011-10-05 04:23:56 PDT
Created attachment 564791 [details] [diff] [review]
Factor out interface for backend-dependent gunk, add comments.

Gah, qref.
Comment 2 Chris Leary [:cdleary] (not checking bugmail) 2011-10-07 11:42:05 PDT
Comment on attachment 564791 [details] [diff] [review]
Factor out interface for backend-dependent gunk, add comments.

Luke said he would be willing to review this one too.
Comment 3 Luke Wagner [:luke] 2011-10-07 11:46:57 PDT
Comment on attachment 564791 [details] [diff] [review]
Factor out interface for backend-dependent gunk, add comments.

Nice.
Comment 4 Chris Leary [:cdleary] (not checking bugmail) 2011-10-07 16:34:37 PDT
Followup to unburn no-methodjit config: https://hg.mozilla.org/integration/mozilla-inbound/rev/e39362de752f

See bug 661974 comment 3.

Note You need to log in before you can comment on or make changes to this bug.