Closed
Bug 692078
Opened 14 years ago
Closed 14 years ago
Second attempt to open addons.sqlite is doesn't work
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
VERIFIED
FIXED
mozilla10
Tracking | Status | |
---|---|---|
firefox9 | --- | fixed |
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
(Whiteboard: [qa!])
Attachments
(1 file, 2 obsolete files)
4.73 KB,
patch
|
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When I added the test from bug 689375 to mozilla-central I discovered the code I refactored into the tryAgain function no longer works (|this| is undefined inside the function).
This patch includes said test.
Attachment #564801 -
Flags: review?(dtownsend)
Updated•14 years ago
|
Attachment #564801 -
Flags: review?(dtownsend) → review+
Comment 1•14 years ago
|
||
fwiw, you may use bind(this) on the helper function
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to Marco Bonardo [:mak] from comment #1)
> fwiw, you may use bind(this) on the helper function
That's probably a better way of doing it.
Attachment #564801 -
Attachment is obsolete: true
Attachment #565059 -
Flags: review?(dtownsend)
Updated•14 years ago
|
Attachment #565059 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•14 years ago
|
Attachment #565059 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 3•14 years ago
|
||
Pushing this to try since inbound is a mess currently, and I probably should've anyway.
https://tbpl.mozilla.org/?tree=Try&rev=97fbefeb0ee9
Keywords: checkin-needed
Comment 5•14 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla10
Comment 6•14 years ago
|
||
Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae27b467720c
Relanded with correct bug number (my bad, I should have double checked):
https://hg.mozilla.org/integration/mozilla-inbound/rev/97f2cd5ea1ee
Assignee | ||
Comment 7•14 years ago
|
||
Same patch, with a proper commit message to prevent the wrong bug number landing on aurora.
Obligatory aurora approval comment: this is needed to prevent future changes to addons.sqlite breaking for users who use the same profile on different versions. With tests.
Attachment #565059 -
Attachment is obsolete: true
Attachment #565059 -
Flags: approval-mozilla-aurora?
Attachment #565491 -
Flags: approval-mozilla-aurora?
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Attachment #565491 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [land on mozilla-aurora]
Comment 9•14 years ago
|
||
Comment 10•14 years ago
|
||
For the record -- LegNeato mistakenly landed a partial version of this bug's patch on mozilla-beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/ad88c42b0255
and backed out because it caused timeouts in all testsuites (since it was missing most of the patch):
https://hg.mozilla.org/releases/mozilla-beta/rev/dd943de3de11
(IIUC, the patch here isn't supposed to land on mozilla-beta anyway -- I think the fact that it landed there (even in part) was a mistake?)
Comment 11•14 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #10)
> (IIUC, the patch here isn't supposed to land on mozilla-beta anyway -- I
> think the fact that it landed there (even in part) was a mistake?)
Correct. The code it fixes (from bug 664895) isn't even in mozilla-beta.
Assignee | ||
Updated•14 years ago
|
Comment 12•14 years ago
|
||
WTF was I doing? Sorry about that folks.
Comment 14•14 years ago
|
||
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #13)
> Is there something QA can do to verify this fix?
If you replace addons.sqlite with a corrupt db (just a text file would do) then open Firefox and the add-ons manager, the db should get re-created to a normal sqlite file and after a background update check will pull ratings etc. from AMO.
Comment 15•14 years ago
|
||
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0
Verified on Firefox9Beta3, Firefox 10 and 11 on Mac OS 10.6, Ubuntu 11.10, Windows 7 and XP. Replaced the file with a text document. The "addons.sqlite" file is recreated after opening Add-ons manager to its size.
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Whiteboard: [qa+] → [qa!]
You need to log in
before you can comment on or make changes to this bug.
Description
•