Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Second attempt to open addons.sqlite is doesn't work

VERIFIED FIXED in Firefox 9

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

9 Branch
mozilla10
Points:
---
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(firefox9 fixed)

Details

(Whiteboard: [qa!])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 564801 [details] [diff] [review]
patch and test

When I added the test from bug 689375 to mozilla-central I discovered the code I refactored into the tryAgain function no longer works (|this| is undefined inside the function).

This patch includes said test.
Attachment #564801 - Flags: review?(dtownsend)
Attachment #564801 - Flags: review?(dtownsend) → review+
fwiw, you may use bind(this) on the helper function
(Assignee)

Comment 2

6 years ago
Created attachment 565059 [details] [diff] [review]
patch using bind()

(In reply to Marco Bonardo [:mak] from comment #1)
> fwiw, you may use bind(this) on the helper function

That's probably a better way of doing it.
Attachment #564801 - Attachment is obsolete: true
Attachment #565059 - Flags: review?(dtownsend)
Attachment #565059 - Flags: review?(dtownsend) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Updated

6 years ago
Attachment #565059 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 3

6 years ago
Pushing this to try since inbound is a mess currently, and I probably should've anyway.
https://tbpl.mozilla.org/?tree=Try&rev=97fbefeb0ee9
Keywords: checkin-needed
(Assignee)

Comment 4

6 years ago
Try looks good, let's go!
Keywords: checkin-needed

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef21d6f2187d
Keywords: checkin-needed
Target Milestone: --- → mozilla10

Comment 6

6 years ago
Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae27b467720c

Relanded with correct bug number (my bad, I should have double checked):
https://hg.mozilla.org/integration/mozilla-inbound/rev/97f2cd5ea1ee
(Assignee)

Comment 7

6 years ago
Created attachment 565491 [details] [diff] [review]
patch with proper commit message

Same patch, with a proper commit message to prevent the wrong bug number landing on aurora.

Obligatory aurora approval comment: this is needed to prevent future changes to addons.sqlite breaking for users who use the same profile on different versions. With tests.
Attachment #565059 - Attachment is obsolete: true
Attachment #565059 - Flags: approval-mozilla-aurora?
Attachment #565491 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/97f2cd5ea1ee
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Attachment #565491 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [land on mozilla-aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/87be7145a73e
Flags: in-testsuite+
Flags: in-litmus-
Keywords: checkin-needed
Whiteboard: [land on mozilla-aurora]
For the record -- LegNeato mistakenly landed a partial version of this bug's patch on mozilla-beta:
  https://hg.mozilla.org/releases/mozilla-beta/rev/ad88c42b0255
and backed out because it caused timeouts in all testsuites (since it was missing most of the patch):
  https://hg.mozilla.org/releases/mozilla-beta/rev/dd943de3de11

(IIUC, the patch here isn't supposed to land on mozilla-beta anyway -- I think the fact that it landed there (even in part) was a mistake?)
(In reply to Daniel Holbert [:dholbert] from comment #10)
> (IIUC, the patch here isn't supposed to land on mozilla-beta anyway -- I
> think the fact that it landed there (even in part) was a mistake?)

Correct. The code it fixes (from bug 664895) isn't even in mozilla-beta.
(Assignee)

Updated

6 years ago
status-firefox9: affected → fixed

Comment 12

6 years ago
WTF was I doing? Sorry about that folks.
Is there something QA can do to verify this fix?
Whiteboard: [qa+]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #13)
> Is there something QA can do to verify this fix?

If you replace addons.sqlite with a corrupt db (just a text file would do) then open Firefox and the add-ons manager, the db should get re-created to a normal sqlite file and after a background update check will pull ratings etc. from AMO.
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0

Verified on Firefox9Beta3, Firefox 10 and 11 on Mac OS 10.6, Ubuntu 11.10, Windows 7 and XP. Replaced the file with a text document. The "addons.sqlite" file is recreated after opening Add-ons manager to its size.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.