692269 - Remove jsstr.h and vm/String.h from INSTALLED_HEADERS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Any takers?

Comment 1

[Luke Wagner [:luke]]

I can.  Does this depend on jscntxt.h removal?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Luke Wagner [:luke] from comment #1)
> I can.  Does this depend on jscntxt.h removal?

I don't think so.

Comment 3

[Luke Wagner [:luke]]

Attachment: un-install vm/String.h and some others

The patch also kills some random installed headers that were easy: jsautokw.h, jsclone.h, jsopcode.tbl, jsopcode.h, jsstdint.h.

Comment 4

[Luke Wagner [:luke]]

Green on try

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 592560 [details] [diff] [review]
un-install vm/String.h and some others

Review of attachment 592560 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsatominlines.h
@@ +198,5 @@
>  }
>  
> +inline
> +AtomHasher::Lookup::Lookup(const JSAtom *atom)
> + : chars(atom->chars()), length(atom->length()), atom(atom)

I think we usually have two spaces before the : here.

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5ff7098d6a4

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f5ff7098d6a4