Last Comment Bug 692269 - Remove jsstr.h and vm/String.h from INSTALLED_HEADERS
: Remove jsstr.h and vm/String.h from INSTALLED_HEADERS
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla13
Assigned To: Luke Wagner [:luke]
:
Mentors:
Depends on:
Blocks: 554088
  Show dependency treegraph
 
Reported: 2011-10-05 14:14 PDT by Bill McCloskey (:billm)
Modified: 2012-02-03 10:55 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
un-install vm/String.h and some others (17.29 KB, patch)
2012-01-29 17:36 PST, Luke Wagner [:luke]
wmccloskey: review+
Details | Diff | Splinter Review

Description Bill McCloskey (:billm) 2011-10-05 14:14:18 PDT
Any takers?
Comment 1 Luke Wagner [:luke] 2011-10-05 14:37:43 PDT
I can.  Does this depend on jscntxt.h removal?
Comment 2 Bill McCloskey (:billm) 2011-10-05 14:43:08 PDT
(In reply to Luke Wagner [:luke] from comment #1)
> I can.  Does this depend on jscntxt.h removal?

I don't think so.
Comment 3 Luke Wagner [:luke] 2012-01-29 17:36:40 PST
Created attachment 592560 [details] [diff] [review]
un-install vm/String.h and some others

The patch also kills some random installed headers that were easy: jsautokw.h, jsclone.h, jsopcode.tbl, jsopcode.h, jsstdint.h.
Comment 4 Luke Wagner [:luke] 2012-01-30 08:41:43 PST
Green on try
Comment 5 Bill McCloskey (:billm) 2012-02-01 17:15:33 PST
Comment on attachment 592560 [details] [diff] [review]
un-install vm/String.h and some others

Review of attachment 592560 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsatominlines.h
@@ +198,5 @@
>  }
>  
> +inline
> +AtomHasher::Lookup::Lookup(const JSAtom *atom)
> + : chars(atom->chars()), length(atom->length()), atom(atom)

I think we usually have two spaces before the : here.
Comment 7 Ed Morley [:emorley] 2012-02-03 10:55:38 PST
https://hg.mozilla.org/mozilla-central/rev/f5ff7098d6a4

Note You need to log in before you can comment on or make changes to this bug.