Closed Bug 692269 Opened 10 years ago Closed 10 years ago

Remove jsstr.h and vm/String.h from INSTALLED_HEADERS

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: billm, Assigned: luke)

References

Details

Attachments

(1 file)

I can.  Does this depend on jscntxt.h removal?
(In reply to Luke Wagner [:luke] from comment #1)
> I can.  Does this depend on jscntxt.h removal?

I don't think so.
Blocks: 554088
The patch also kills some random installed headers that were easy: jsautokw.h, jsclone.h, jsopcode.tbl, jsopcode.h, jsstdint.h.
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #592560 - Flags: review?(wmccloskey)
Green on try
Comment on attachment 592560 [details] [diff] [review]
un-install vm/String.h and some others

Review of attachment 592560 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsatominlines.h
@@ +198,5 @@
>  }
>  
> +inline
> +AtomHasher::Lookup::Lookup(const JSAtom *atom)
> + : chars(atom->chars()), length(atom->length()), atom(atom)

I think we usually have two spaces before the : here.
Attachment #592560 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/f5ff7098d6a4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.