Closed Bug 692332 Opened 10 years ago Closed 10 years ago

IonMonkey: Miscompilation of 1/x.

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sstangl, Unassigned)

Details

Attachments

(2 files)

The following code miscompiles on x64:
> function f(x) { return 1/x; }

f(3) returns 1. The MIR is correct, but the LIR contains two LInteger(1) instructions, and the generated assembly overwrites the parameter of |3| with |1|, although the regalloc does not show any intended use of that register.

Fixing this fixes SS' math-spectral-norm.
Attached image LIR
Oh, the LIR is just totally incorrect. It is explicitly calculating 1/1 (v4,v5).
Attached patch supSplinter Review
Attachment #565089 - Flags: review?(dvander)
http://hg.mozilla.org/projects/ionmonkey/rev/86b68bdba42f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.