692358 - log uploading missing for PGO builds and unit tests, incorrect for talos

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

Log uploading is missing for PGO builds and unit tests.  The fallout of this is that no logs get uploaded for builds or unit tests.

Log uploading is incorrect for PGO talos.  The fallout of this is that logs go to the wrong place.

example:

for a build that ends up here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32-pgo/1317841203/

logs for talos end up here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1317841203/

I have a patch that I am testing right now on dev-master that corrects the talos log upload location and adds log uploads for build and unit tests.

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbotcustom patch that should fix this issue

This should be correct, given my understanding of how log uploading works.  It is properly setting the -p flag in build, unit test and talos cases (at least to my understanding of the log_upload.py script).  For whatever reason, I have yet to see the results of these commands be a log uploaded to the correct location.

["/home/jford/masters/bin/python2.6", "/home/jford/masters/buildbotcustom/bin/log_uploader.py", "dev-stage01.build.sjc1.mozilla.com", "-u", "ffxbld", "-i", "/home/jford/.ssh/ffxbld_dsa", "-b", "mozilla-central", "-p", "linux-pgo", "--product", "firefox", "/home/jford/masters/builder-master/mozilla-central-linux-pgo", "10"]

["/home/jford/masters/bin/python2.6", "/home/jford/masters/buildbotcustom/bin/log_uploader.py", "dev-stage01.build.sjc1.mozilla.com", "-u", "ffxbld", "-i", "/home/jford/.ssh/ffxbld_dsa", "-b", "mozilla-central", "-p", "linux-pgo", "--product", "firefox", "/home/jford/masters/test-master/mozilla-central_fedora_test_pgo-mochitest-other", "0"]


["/home/jford/masters/bin/python2.6", "/home/jford/masters/buildbotcustom/bin/log_uploader.py", "dev-stage01.build.sjc1.mozilla.com", "-u", "ffxbld", "-i", "/home/jford/.ssh/ffxbld_dsa", "-b", "mozilla-central", "-p", "linux-pgo", "--product", "firefox", "/home/jford/masters/test-master/mozilla-central_fedora_test-svg-pgo", "0"]

Comment 2

[Phil Ringnalda (:philor)]

Fixed many moons ago.