692392 - Advanced Search misses all search fields

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[:Hb]

The Advanced Address Book Search dialog has two dropdowns in the criteria list.  The first one should have the target column names and the second one the condition operators. Both dropdowns are empty. 

Advanced Search is therefore completely broken.

Confirmed on Version 2.4 and on Trunk, perhaps a bug since 2.x.

Comment 1

[Philip Chee]

Error: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]
Source file: chrome://messenger/content/ABSearchDialog.js
Line: 155

Probably fallout from deRDF addressbook bug.

function GetScopeForDirectoryURI(aURI)
{
  var directory = gRDF.GetResource(aURI).QueryInterface(nsIAbDirectory);
Should be:
  var directory = MailServices.ab.getDirectory(aURI);

See Bug 652855 and http://hg.mozilla.org/comm-central/rev/e3f147cb26aa#l1.1

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Bah, seems I missed this in bug 654864 because I only referred to abCommon.js in my bug 652855 comment. :-(

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 5]

Going for MOA

Comment 4

[:Hb]

I tested the patch with a homebrew non optimized omni.jar. Target columns and conditions appear now. Search works fine when started with the Search button or typing Alt+S.

But when the search is started by Enter key after typing in the condition text the dialog window closes completely without result. This behaviour may be another bug.

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 565305 [details] [diff] [review]
patch [Checkin: comment 5]

http://hg.mozilla.org/comm-central/rev/1878d5d66a78
http://hg.mozilla.org/releases/comm-aurora/rev/e9cb3f0268cf
http://hg.mozilla.org/releases/comm-beta/rev/75c1190bc182