Last Comment Bug 692392 - Advanced Search misses all search fields
: Advanced Search misses all search fields
Product: SeaMonkey
Classification: Client Software
Component: MailNews: Address Book & Contacts (show other bugs)
: Trunk
: All All
-- major (vote)
: seamonkey2.7
Assigned To: Jens Hatlak (:InvisibleSmiley)
Depends on: 652855
  Show dependency treegraph
Reported: 2011-10-06 00:34 PDT by :Hb
Modified: 2011-10-11 12:12 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

patch [Checkin: comment 5] (2.20 KB, patch)
2011-10-06 12:09 PDT, Jens Hatlak (:InvisibleSmiley)
mnyromyr: review+
neil: superreview+
neil: approval‑comm‑aurora+
neil: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image :Hb 2011-10-06 00:34:36 PDT
The Advanced Address Book Search dialog has two dropdowns in the criteria list.  The first one should have the target column names and the second one the condition operators. Both dropdowns are empty. 

Advanced Search is therefore completely broken.

Confirmed on Version 2.4 and on Trunk, perhaps a bug since 2.x.
Comment 1 User image Philip Chee 2011-10-06 11:27:00 PDT
Error: Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]
Source file: chrome://messenger/content/ABSearchDialog.js
Line: 155

Probably fallout from deRDF addressbook bug.

function GetScopeForDirectoryURI(aURI)
  var directory = gRDF.GetResource(aURI).QueryInterface(nsIAbDirectory);
Should be:
  var directory = MailServices.ab.getDirectory(aURI);

See Bug 652855 and
Comment 2 User image Jens Hatlak (:InvisibleSmiley) 2011-10-06 12:05:36 PDT
Bah, seems I missed this in bug 654864 because I only referred to abCommon.js in my bug 652855 comment. :-(
Comment 3 User image Jens Hatlak (:InvisibleSmiley) 2011-10-06 12:09:47 PDT
Created attachment 565305 [details] [diff] [review]
patch [Checkin: comment 5]

Going for MOA
Comment 4 User image :Hb 2011-10-06 23:38:54 PDT
I tested the patch with a homebrew non optimized omni.jar. Target columns and conditions appear now. Search works fine when started with the Search button or typing Alt+S.

But when the search is started by Enter key after typing in the condition text the dialog window closes completely without result. This behaviour may be another bug.

Note You need to log in before you can comment on or make changes to this bug.