== instead of = when trying to assign a new encoding name in XHR

RESOLVED FIXED in Firefox 9

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
mozilla10
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox9 fixed, firefox10 fixed)

Details

(Whiteboard: [qa-], URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 687087 introduced this:
if (mResponseCharset != document->GetDocumentCharacterSet()) {
  mResponseCharset == document->GetDocumentCharacterSet();

Should be
if (mResponseCharset != document->GetDocumentCharacterSet()) {
  mResponseCharset = document->GetDocumentCharacterSet();

(== vs. =)

Comment 1

6 years ago
Need to fix this asap, since Bug 687087 is in Aurora.
Assignee: nobody → jonas
(Assignee)

Updated

6 years ago
Summary: == instead of = when trying to assign a new encoding converter in XHR → == instead of = when trying to assign a new encoding name in XHR
(Assignee)

Updated

6 years ago
Blocks: 651072
(Assignee)

Comment 2

6 years ago
Created attachment 565480 [details] [diff] [review]
Use = instead of ==, with a test

Taking. I need this fixed for bug 651072.
Assignee: jonas → hsivonen
Status: NEW → ASSIGNED
Attachment #565480 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #565480 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bae7a490cb0
Flags: in-testsuite+
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
(Assignee)

Comment 4

6 years ago
Comment on attachment 565480 [details] [diff] [review]
Use = instead of ==, with a test

Requesting approval for Aurora. The code that has the extra equals sign was recently introduced but has made it to Aurora already. Letting it get to release could at least in theory break cases where XHR is used for reading non-UTF-8 XML as text.
Attachment #565480 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/6bae7a490cb0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-firefox10: --- → fixed
status-firefox9: --- → affected
Resolution: --- → FIXED
Whiteboard: [inbound]
I wonder if we can make the compiler error here.  On Windows we're already erroring for "lvalue == rvalue;" for primitive types.

Updated

6 years ago
Attachment #565480 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/939e5e3e2015
status-firefox9: affected → fixed
tracking-firefox9: ? → ---
[qa-] because of code related issue.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.