692504 - push betas to internal mirrors automatically

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

Betas should get pushed to internal mirrors automatically. This should be pretty easy, because there's no rsync modules to update (because we exclude *.*b* from mozilla-releases already). We probably need a flag in the release config to control this behaviour.

Comment 1

[Rail Aliiev [:rail]]

We can push the files after the "updates" or antivirus builder. Probably the latter is better. Any other suggestion?

Comment 2

[[e-mail] (:bhearsum)]

Yeah, pushing after A/V is probably best for Betas.

Comment 3

[Rail Aliiev [:rail]]

For betas: we need to disable "updates available on betatest" emails and add "updates available on releasetest" emails ~10 mins after pushing the files to the internal mirrors.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Rail Aliiev [:rail] from comment #3)
> For betas: we need to disable "updates available on betatest" emails and add
> "updates available on releasetest" emails ~10 mins after pushing the files
> to the internal mirrors.

The comment about releasetest confuses me, as we already get a 'ready for releasetest testing' email when we get to weight 1 in bouncer (ie when sentry polls dm-download02). +1 to disabling the betatest emails though.

Comment 5

[Rail Aliiev [:rail]]

(In reply to Nick Thomas [:nthomas] from comment #4)
> 
> The comment about releasetest confuses me, as we already get a 'ready for
> releasetest testing' email when we get to weight 1 in bouncer (ie when
> sentry polls dm-download02). +1 to disabling the betatest emails though.

Oh, right.

Comment 6

[Rail Aliiev [:rail]]

Attachment: configs

Comment 7

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

to be tested

Comment 8

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

Passed staging test

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 567924 [details] [diff] [review]
buildbotcustom

Review of attachment 567924 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/release.py
@@ +485,5 @@
> +    if releaseConfig.get('enableAutomaticPushToMirrors') and \
> +        releaseConfig.get('verifyConfigs'):
> +        upstream_scheduler = updates_scheduler
> +        if not releaseConfig.get('disableVirusCheck'):
> +            upstream_scheduler = antivirus_scheduler

Can you reverse this logic? Using "if not" on variable starting with "disable" is a bit confusing.

Comment 10

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 568055 [details] [diff] [review]
buildbotcustom

Updated patch, r=bhearsum via IRC.

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 567145 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/40d6781359db

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 568055 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/67441a25106f

Comment 14

[Chris Cooper [:coop] (he/him)]

A reconfig that included this happened today.