push betas to internal mirrors automatically

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: bhearsum, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Betas should get pushed to internal mirrors automatically. This should be pretty easy, because there's no rsync modules to update (because we exclude *.*b* from mozilla-releases already). We probably need a flag in the release config to control this behaviour.
(Assignee)

Updated

6 years ago
Assignee: nobody → rail
Priority: -- → P4
(Assignee)

Updated

6 years ago
Priority: P4 → P2
(Assignee)

Comment 1

6 years ago
We can push the files after the "updates" or antivirus builder. Probably the latter is better. Any other suggestion?
(Reporter)

Comment 2

6 years ago
Yeah, pushing after A/V is probably best for Betas.
(Assignee)

Comment 3

6 years ago
For betas: we need to disable "updates available on betatest" emails and add "updates available on releasetest" emails ~10 mins after pushing the files to the internal mirrors.
(In reply to Rail Aliiev [:rail] from comment #3)
> For betas: we need to disable "updates available on betatest" emails and add
> "updates available on releasetest" emails ~10 mins after pushing the files
> to the internal mirrors.

The comment about releasetest confuses me, as we already get a 'ready for releasetest testing' email when we get to weight 1 in bouncer (ie when sentry polls dm-download02). +1 to disabling the betatest emails though.
(Assignee)

Comment 5

6 years ago
(In reply to Nick Thomas [:nthomas] from comment #4)
> 
> The comment about releasetest confuses me, as we already get a 'ready for
> releasetest testing' email when we get to weight 1 in bouncer (ie when
> sentry polls dm-download02). +1 to disabling the betatest emails though.

Oh, right.
(Assignee)

Comment 6

6 years ago
Created attachment 567145 [details] [diff] [review]
configs
(Assignee)

Comment 7

6 years ago
Created attachment 567146 [details] [diff] [review]
buildbotcustom

to be tested
(Assignee)

Comment 8

6 years ago
Created attachment 567924 [details] [diff] [review]
buildbotcustom

Passed staging test
Attachment #567146 - Attachment is obsolete: true
Attachment #567924 - Flags: review?(bhearsum)
(Assignee)

Updated

6 years ago
Attachment #567145 - Flags: review?(bhearsum)
(Reporter)

Comment 9

6 years ago
Comment on attachment 567924 [details] [diff] [review]
buildbotcustom

Review of attachment 567924 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/release.py
@@ +485,5 @@
> +    if releaseConfig.get('enableAutomaticPushToMirrors') and \
> +        releaseConfig.get('verifyConfigs'):
> +        upstream_scheduler = updates_scheduler
> +        if not releaseConfig.get('disableVirusCheck'):
> +            upstream_scheduler = antivirus_scheduler

Can you reverse this logic? Using "if not" on variable starting with "disable" is a bit confusing.
Attachment #567924 - Flags: review?(bhearsum) → review+
(Reporter)

Updated

6 years ago
Attachment #567145 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 10

6 years ago
Created attachment 568055 [details] [diff] [review]
buildbotcustom
(Assignee)

Comment 11

6 years ago
Comment on attachment 568055 [details] [diff] [review]
buildbotcustom

Updated patch, r=bhearsum via IRC.
Attachment #568055 - Attachment description: bui → buildbotcustom
Attachment #568055 - Flags: review+
(Assignee)

Updated

6 years ago
Attachment #567924 - Attachment is obsolete: true
(Assignee)

Comment 12

6 years ago
Comment on attachment 567145 [details] [diff] [review]
configs

http://hg.mozilla.org/build/buildbot-configs/rev/40d6781359db
Attachment #567145 - Flags: checked-in+
(Assignee)

Comment 13

6 years ago
Comment on attachment 568055 [details] [diff] [review]
buildbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/67441a25106f
Attachment #568055 - Flags: checked-in+
A reconfig that included this happened today.
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.