Closed
Bug 692617
Opened 14 years ago
Closed 7 years ago
Blocklist UI doesn't correctly scale large icons
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: mossop, Unassigned)
Details
See bug 690819 attachment 565300 [details] for an example where an add-on was using a large web image for its icon, the blocklist UI can't cope with it.
|
||
Comment 1•7 years ago
|
||
Do we still have this UI? Can this still happen with webextensions? I assume we can just close this...
Flags: needinfo?(dtownsend)
|
Reporter | |
Updated•7 years ago
|
Flags: needinfo?(dtownsend) → needinfo?(aswan)
|
||
Comment 2•7 years ago
|
||
Huh, I've never seen that dialog but tracing through the block list service:
https://searchfox.org/mozilla-central/rev/b9f1a4ecba48b2d8c686669e32d109c40e927b48/toolkit/mozapps/extensions/nsBlocklistService.js#1257-1437
and the dialog it launches from line 1432:
https://searchfox.org/mozilla-central/rev/b9f1a4ecba48b2d8c686669e32d109c40e927b48/toolkit/mozapps/extensions/content/blocklist.js
It looks like the UI is still present and furthermore that the restart language is displayed regardless of whether affected addons require a restart. I guess the silver lining here is that webextensions (and themes, langpacks, etc) cannot use images from the web as their icons so this specific bug can be resolved, I'll follow up with Jorge about ripping out that whole UI now that everything is restartless.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(aswan)
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•