692635 - IndexedDB: abort event should bubble

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We should also add a IDBDatabase.onabort property.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 576136 [details] [diff] [review]
Patch

Review of attachment 576136 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: dom/indexedDB/IDBEvents.cpp
@@ +83,3 @@
>  {
> +  NS_ASSERTION(aCancelable == eNotCancelable || aBubbles == eDoesBubble,
> +               "Event cannot be cancelable if it does not bubble!");

I don't really agree with this assertion. This might be true for all of the current indexeddb events, but it's not an inherent property in any way.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Ah, I thought it was.  I'll remove that.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/a1d3b55dc132

Comment 6

[Chris Mills [:cmills]]

This has been documented, see

https://developer.mozilla.org/en-US/docs/Web/Events/abort_indexedDB
https://developer.mozilla.org/en-US/docs/Web/API/IDBDatabase/onabort

I also added a note to

https://developer.mozilla.org/en-US/Firefox/Releases/11#IndexedDB