Closed Bug 692635 Opened 8 years ago Closed 8 years ago

IndexedDB: abort event should bubble

Categories

(Core :: DOM: IndexedDB, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sicking, Assigned: khuey)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

No description provided.
We should also add a IDBDatabase.onabort property.
Assignee: nobody → khuey
Comment on attachment 576136 [details] [diff] [review]
Patch

Review of attachment 576136 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: dom/indexedDB/IDBEvents.cpp
@@ +83,3 @@
>  {
> +  NS_ASSERTION(aCancelable == eNotCancelable || aBubbles == eDoesBubble,
> +               "Event cannot be cancelable if it does not bubble!");

I don't really agree with this assertion. This might be true for all of the current indexeddb events, but it's not an inherent property in any way.
Attachment #576136 - Flags: review?(bent.mozilla) → review+
Ah, I thought it was.  I'll remove that.
https://hg.mozilla.org/mozilla-central/rev/a1d3b55dc132
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla11 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.