Last Comment Bug 692635 - IndexedDB: abort event should bubble
: IndexedDB: abort event should bubble
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM: IndexedDB (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
:
Mentors:
Depends on:
Blocks: idb
  Show dependency treegraph
 
Reported: 2011-10-06 15:51 PDT by Jonas Sicking (:sicking) No longer reading bugmail consistently
Modified: 2015-12-01 02:09 PST (History)
6 users (show)
khuey: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (12.68 KB, patch)
2011-11-22 06:04 PST, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
jonas: review+
Details | Diff | Splinter Review

Description Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-10-06 15:51:00 PDT

    
Comment 1 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-10-07 16:45:03 PDT
We should also add a IDBDatabase.onabort property.
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-11-22 06:04:04 PST
Created attachment 576136 [details] [diff] [review]
Patch
Comment 3 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-11-22 08:37:01 PST
Comment on attachment 576136 [details] [diff] [review]
Patch

Review of attachment 576136 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: dom/indexedDB/IDBEvents.cpp
@@ +83,3 @@
>  {
> +  NS_ASSERTION(aCancelable == eNotCancelable || aBubbles == eDoesBubble,
> +               "Event cannot be cancelable if it does not bubble!");

I don't really agree with this assertion. This might be true for all of the current indexeddb events, but it's not an inherent property in any way.
Comment 4 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-11-22 08:38:18 PST
Ah, I thought it was.  I'll remove that.
Comment 5 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-11-23 06:17:10 PST
https://hg.mozilla.org/mozilla-central/rev/a1d3b55dc132

Note You need to log in before you can comment on or make changes to this bug.