Closed
Bug 692674
Opened 14 years ago
Closed 14 years ago
IndexedDB: Set the errorCode to "ABORT_ERR" for *all* pending requests when IDBTransaction.abort() is called
Categories
(Core :: Storage: IndexedDB, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sicking, Assigned: sicking)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
5.34 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Currently we only do this on requests which are successful.
|
Assignee | |
Comment 1•14 years ago
|
||
Comment on attachment 572737 [details] [diff] [review]
Patch to fix
Review of attachment 572737 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/indexedDB/AsyncConnectionHelper.cpp
@@ +228,2 @@
> // Don't fire success events if the transaction has since been aborted.
> // Instead convert to an error event.
Nit: Fix this comment to say something about always firing ABORT_ERR for success and other errors?
Attachment #572737 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Checked in https://hg.mozilla.org/mozilla-central/rev/c131defb532c
Thanks for quick review!
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
||
Updated•14 years ago
|
Keywords: dev-doc-needed
|
||
Comment 4•14 years ago
|
||
I've updated:
https://developer.mozilla.org/en/IndexedDB/IDBTransaction#section_11
https://developer.mozilla.org/en/Firefox_10_for_developers#IndexedDB
https://developer.mozilla.org/en/IndexedDB/IDBRequest was already up-to-date.
Keywords: dev-doc-needed → dev-doc-complete
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla10 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•