IndexedDB: Set the errorCode to "ABORT_ERR" for *all* pending requests when IDBTransaction.abort() is called

RESOLVED FIXED

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

({dev-doc-complete})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

5.34 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Currently we only do this on requests which are successful.
Created attachment 572737 [details] [diff] [review]
Patch to fix
Assignee: nobody → jonas
Status: NEW → ASSIGNED
Attachment #572737 - Flags: review?(bent.mozilla)
Comment on attachment 572737 [details] [diff] [review]
Patch to fix

Review of attachment 572737 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/AsyncConnectionHelper.cpp
@@ +228,2 @@
>        // Don't fire success events if the transaction has since been aborted.
>        // Instead convert to an error event.

Nit: Fix this comment to say something about always firing ABORT_ERR for success and other errors?
Attachment #572737 - Flags: review?(bent.mozilla) → review+
Checked in https://hg.mozilla.org/mozilla-central/rev/c131defb532c

Thanks for quick review!
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Keywords: dev-doc-needed
I've updated:
https://developer.mozilla.org/en/IndexedDB/IDBTransaction#section_11
https://developer.mozilla.org/en/Firefox_10_for_developers#IndexedDB

https://developer.mozilla.org/en/IndexedDB/IDBRequest was already up-to-date.
Keywords: dev-doc-needed → dev-doc-complete
Component: DOM → DOM: IndexedDB
Target Milestone: mozilla10 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.