692674 - IndexedDB: Set the errorCode to "ABORT_ERR" for *all* pending requests when IDBTransaction.abort() is called

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Currently we only do this on requests which are successful.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 572737 [details] [diff] [review]
Patch to fix

Review of attachment 572737 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/AsyncConnectionHelper.cpp
@@ +228,2 @@
>        // Don't fire success events if the transaction has since been aborted.
>        // Instead convert to an error event.

Nit: Fix this comment to say something about always firing ABORT_ERR for success and other errors?

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in https://hg.mozilla.org/mozilla-central/rev/c131defb532c

Thanks for quick review!

Comment 4

[Jean-Yves Perrier [:teoli]]

I've updated:
https://developer.mozilla.org/en/IndexedDB/IDBTransaction#section_11
https://developer.mozilla.org/en/Firefox_10_for_developers#IndexedDB

https://developer.mozilla.org/en/IndexedDB/IDBRequest was already up-to-date.