Closed
Bug 692765
Opened 13 years ago
Closed 13 years ago
Adapt Modern for restartless dictionaries support
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.7
People
(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)
References
Details
Attachments
(1 file)
13.08 KB,
patch
|
philip.chee
:
review+
|
Details | Diff | Splinter Review |
Bug 591780 (restartless dictionaries) introduced new icons and matching CSS. Modern needs to be adapted. Original changeset introducing the styles: <http://hg.mozilla.org/mozilla-central/rev/6f4259bdadf5>
Assignee | ||
Comment 1•13 years ago
|
||
Philip, I hope you can review this; I'm trying to reduce Neil's burden. I didn't find a restartless dictionary add-on to test this so I did: 1. Open about:addons 2. Ctrl+Shift+I to open DOMI with the current content page 3. Ctrl+F "-dict" to find #category-dictionary 4. Delete hidden=true entry on the right pane Like in bug 568052 I copied the icons from winstripe, then made the CSS and jar.mn changes. I found that changes had been made to two new files (newaddon.css from bug 476430 and selectAddons.css from bug 596343) so I skipped those (to be done in further Modern porting bugs; I guess we'll need several). Also, additions were made to a block in xpinstallConfirm.css that had been added in bug 572043 which we haven't ported yet (like so many others). I chose to copy the block since it's pretty self-contained and uses existing icons. Original changesets: https://hg.mozilla.org/mozilla-central/rev/6f4259bdadf5#l31.1 http://hg.mozilla.org/mozilla-central/rev/e3ccdd93ba10#l85.1
Comment 2•13 years ago
|
||
Comment on attachment 565761 [details] [diff] [review] patch [Checkin: comment 4] r=me > Also, additions were made to a block in xpinstallConfirm.css that had been > added in bug 572043 which we haven't ported yet (like so many others). I chose > to copy the block since it's pretty self-contained and uses existing icons. Please file a bug if you haven't already done so. Thanks. > +#eula-dialog[addontype="dictionary"] #icon { > + list-style-image: url("chrome://mozapps/skin/extensions/dictionaryGeneric.png"); > +} Managed to test everything except this part. Didn't find out how to test, but assume it works. The rest works as advertised. > } > +#category-dictionary { > + list-style-image: url("chrome://mozapps/skin/extensions/category-dictionaries.png"); > +} > #category-availableUpdates { [No action needed just a random comment: wonder why there are no blank lines in this section.] p.s. reviewing is hard. Hope I didn't miss anything.
Attachment #565761 -
Flags: review?(philip.chee) → review+
Comment 3•13 years ago
|
||
FYI, the .PNGs are already optimized but in case they are not, Neil recommends doing both the following: pngcrush -rem gAMA -rem cHRM -rem iCCP -rem sRGB contentPluginMissing.png contentPluginMissing-1.png optipng -zc1-9 -zm1-9 -zs0-3 -f0-5 -nx contentPluginMissing.png
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 565761 [details] [diff] [review] patch [Checkin: comment 4] http://hg.mozilla.org/comm-central/rev/959565f8013a
Attachment #565761 -
Attachment description: patch → patch [Checkin: comment 4]
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
You need to log in
before you can comment on or make changes to this bug.
Description
•