about:home shows tabs from last time with wrong encoding, non-ASCII characters are broken

VERIFIED FIXED in Firefox 9

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: aryx, Assigned: mfinkle)

Tracking

({regression, verified-aurora})

Trunk
Firefox 9
ARM
Android
regression, verified-aurora

Details

Attachments

(2 attachments)

Created attachment 565513 [details]
screenshot of about:home with broken character

about:home shows the tabs from last time with a wrong encoding (latin 1?), the special characters are broken.

Steps to reproduce:
1. Open a new tab.
2. Type "österreich" into it and start a google search.
3. Call Menu > More > Quit.
4. Launch Firefox Mobile.

Actual result:
The "ö" is replaced by other characters.

Expected result:
Tab title contains "österreich".

This is a regression only on nightly, starting with 2011-10-05's nightly.
(Assignee)

Updated

6 years ago
Duplicate of this bug: 692797
From bug 692797, comment 1:
This is a regression from bug 691534, which switched to use NetUtils.readInputStreamToString
Blocks: 691534
Fixing nonchalant Americanism in title.
Summary: about:home shows tabs from last time with wrong encoding, special characters are broken → about:home shows tabs from last time with wrong encoding, non-ASCII characters are broken
From duped bug 692797, comment 2:
I thought we were working like the code in Sync:
Saving with UTF-8
http://mxr.mozilla.org/mozilla-central/source/services/sync/modules/util.js#841

Reading without doing anything:
http://mxr.mozilla.org/mozilla-central/source/services/sync/modules/util.js#805
Created attachment 565558 [details] [diff] [review]
patch

This is a regression caused by bug 691534, which switched to use NetUtils.readInputStreamToString and stop converting the UTF-8

This patch reverts part of bug 691534 so we convert the UTF-8
Assignee: nobody → mark.finkle
Attachment #565558 - Flags: review?(mbrubeck)
Comment on attachment 565558 [details] [diff] [review]
patch

Sorry for missing this in review of bug 691534.
Attachment #565558 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3eeb0e021d80
Comment on attachment 565558 [details] [diff] [review]
patch

This patch backs out part of bug 691534, but doesn't affect the performance improvements. It just fixes the UTF-8 character handling.

I think we want this to go along in Aurora with the performance improvements in bug 691534.
Attachment #565558 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/3eeb0e021d80
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII (2.3.4)
Status: RESOLVED → VERIFIED
status-firefox10: --- → fixed

Updated

6 years ago
Attachment #565558 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b707c898e867
status-firefox9: --- → fixed
Target Milestone: Firefox 10 → Firefox 9
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20111019 Firefox/9.0a2 Fennec/9.0a2
Keywords: verified-aurora
You need to log in before you can comment on or make changes to this bug.