692767 - about:home shows tabs from last time with wrong encoding, non-ASCII characters are broken

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of about:home with broken character

about:home shows the tabs from last time with a wrong encoding (latin 1?), the special characters are broken.

Steps to reproduce:
1. Open a new tab.
2. Type "österreich" into it and start a google search.
3. Call Menu > More > Quit.
4. Launch Firefox Mobile.

Actual result:
The "ö" is replaced by other characters.

Expected result:
Tab title contains "österreich".

This is a regression only on nightly, starting with 2011-10-05's nightly.

Comment 2

[Martijn Wargers (dead)]

From bug 692797, comment 1:
This is a regression from bug 691534, which switched to use NetUtils.readInputStreamToString

Comment 3

[Richard Newman [:rnewman]]

Fixing nonchalant Americanism in title.

Comment 4

[Martijn Wargers (dead)]

From duped bug 692797, comment 2:
I thought we were working like the code in Sync:
Saving with UTF-8
http://mxr.mozilla.org/mozilla-central/source/services/sync/modules/util.js#841

Reading without doing anything:
http://mxr.mozilla.org/mozilla-central/source/services/sync/modules/util.js#805

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This is a regression caused by bug 691534, which switched to use NetUtils.readInputStreamToString and stop converting the UTF-8

This patch reverts part of bug 691534 so we convert the UTF-8

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 565558 [details] [diff] [review]
patch

Sorry for missing this in review of bug 691534.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eeb0e021d80

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 565558 [details] [diff] [review]
patch

This patch backs out part of bug 691534, but doesn't affect the performance improvements. It just fixes the UTF-8 character handling.

I think we want this to go along in Aurora with the performance improvements in bug 691534.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/3eeb0e021d80

Comment 10

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII (2.3.4)

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b707c898e867

Comment 12

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20111019 Firefox/9.0a2 Fennec/9.0a2