Failure in testDisableEnablePlugin | controller.waitForEval: Timeout exceeded

RESOLVED WONTFIX

Status

Mozilla QA
Mozmill Tests
RESOLVED WONTFIX
6 years ago
6 years ago

People

(Reporter: RemusPop, Assigned: vladmaniac)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-test-failure][mozmill-test-skipped], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
TEST: /testAddons/testDisableEnablePlugin
ERROR: controller.waitForEval: Timeout exceeded for 'subject.plugin.getPluginState(subject.node, subject.value) == subject.state'
WHEN: 2011-10-07
FIRST: 2011-08-20
BRANCHES: 1.9.2
(Reporter)

Comment 1

6 years ago
A Pivotal Tracker story has been created: https://www.pivotaltracker.com/story/show/19393443
(Reporter)

Comment 2

6 years ago
Created attachment 565524 [details] [diff] [review]
skip test (1.9.2) [checked-in]

This skips the test.
Attachment #565524 - Flags: review?(vlad.mozbugs)
(Assignee)

Comment 3

6 years ago
Comment on attachment 565524 [details] [diff] [review]
skip test (1.9.2) [checked-in]

Looks fine
Attachment #565524 - Flags: review?(vlad.mozbugs) → review+
(Assignee)

Updated

6 years ago
Attachment #565524 - Flags: review+ → review?(anthony.s.hughes)
Attachment #565524 - Flags: review?(anthony.s.hughes) → review+
Comment on attachment 565524 [details] [diff] [review]
skip test (1.9.2) [checked-in]

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/c0b27bf636ab (mozilla-1.9.2)
Attachment #565524 - Attachment description: skip test (1.9.2) → skip test (1.9.2) [checked-in]
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
Depends on: 570008
(Assignee)

Comment 5

6 years ago
This is for 1.9.2 branch and with the new refactoring we'll drop Mozmill support for 1.9.2 

However, waitForEval can be changed with waitFor to fix this test - should we have a fix patch or just close the bug?
(In reply to Maniac Vlad Florin (:vladmaniac) from comment #5)
> This is for 1.9.2 branch and with the new refactoring we'll drop Mozmill
> support for 1.9.2 

What? Who said that we drop support for 1.9.2?
(Assignee)

Comment 7

6 years ago
(In reply to Henrik Skupin (:whimboo) from comment #6)
> (In reply to Maniac Vlad Florin (:vladmaniac) from comment #5)
> > This is for 1.9.2 branch and with the new refactoring we'll drop Mozmill
> > support for 1.9.2 
> 
> What? Who said that we drop support for 1.9.2?

There was a discussion on the mailing list about it some time ago I'll have to check and get back to you
(Assignee)

Comment 8

6 years ago
We are going to drop support only on master so an easy fix would apply here .
Assignee: nobody → vlad.mozbugs
Status: NEW → ASSIGNED
(Assignee)

Comment 9

6 years ago
Created attachment 588021 [details] [diff] [review]
quickfix patch v1.0

Changed waitForEval with waitFor in addons.js on mozilla-1.9.2 branch 

This was not covered by Remus's refactoring waitFor patch for shared modules. 

Also, re-enabled the test by deleting the skip lines.
Attachment #565524 - Attachment is obsolete: true
Attachment #588021 - Flags: review?(anthony.s.hughes)
(In reply to Maniac Vlad Florin (:vladmaniac) from comment #9)
> This was not covered by Remus's refactoring waitFor patch for shared
> modules. 

We have not landed the patch for shared modules on 1.9.2 yet. So not sure if that would make this patch obsolete later today.
(In reply to Henrik Skupin (:whimboo) from comment #10)
> (In reply to Maniac Vlad Florin (:vladmaniac) from comment #9)
> > This was not covered by Remus's refactoring waitFor patch for shared
> > modules. 
> 
> We have not landed the patch for shared modules on 1.9.2 yet. So not sure if
> that would make this patch obsolete later today.

Can you please clarify this statement Henrik? Does this mean that 1.9.2 does not have access to waitFor() and will not until the Shared Modules refactor patch lands? Thanks
It has but I'm waiting for the backport from Remus. Both patches would be in conflict.
(In reply to Henrik Skupin (:whimboo) from comment #12)
> It has but I'm waiting for the backport from Remus. Both patches would be in
> conflict.

You mean Remus' tests refactor patch or is there a separate patch for shared modules I am unaware of?
Yes, it is bug 714802.
Comment on attachment 588021 [details] [diff] [review]
quickfix patch v1.0

(In reply to Henrik Skupin (:whimboo) from comment #14)
> Yes, it is bug 714802.

Thanks Henrik; adding dependency. 

Vlad, please retest and renominate for review after the 1.9.2 patch for bug 714802 has landed. Thanks
Attachment #588021 - Flags: review?(anthony.s.hughes)
Depends on: 714802
Since Firefox 3.6 will be EOL soon, resolving this bug WONTFIX.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.