Last Comment Bug 692821 - Reftests for bug 437722 fail on Android
: Reftests for bug 437722 fail on Android
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-07 09:42 PDT by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2011-10-18 05:35 PDT (History)
6 users (show)
ehsan: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.87 KB, patch)
2011-10-16 20:44 PDT, :Ehsan Akhgari (busy, don't ask for review please)
no flags Details | Diff | Review
Patch (v1) (1.84 KB, patch)
2011-10-16 20:45 PDT, :Ehsan Akhgari (busy, don't ask for review please)
mbrubeck: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2011-10-07 09:42:44 PDT
https://tbpl.mozilla.org/php/getParsedLog.php?id=6726997&tree=Mozilla-Inbound&full=1

I'll disable them on Android for now.
Comment 1 Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( ) 2011-10-07 09:59:26 PDT
Could be a regression.
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-10-07 10:56:34 PDT
Did the tests pass on tryserver?
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-07 13:33:11 PDT
(In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #1)
> Could be a regression.

No, because I just checked them in.  :-)

(In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> Did the tests pass on tryserver?

Now that I checked more closely, they didn't.  And they're perma failures.  But I would like to keep the tests in the tree, since the thing which they're actually testing is working correctly as far as I can tell.
Comment 4 Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( ) 2011-10-07 13:36:41 PDT
I (In reply to Ehsan Akhgari [:ehsan] from comment #3)
> (In reply to Martijn Wargers [:mw22] (QA - IRC nick: mw22) from comment #1)
> > Could be a regression.
> 
> No, because I just checked them in.  :-)

I mean that this reftest could at one point have worked in Fennec, but failed in more recent builds.
Comment 5 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-10-07 13:45:28 PDT
Well, let me note "uncool, man" and slap you on the wrist ;).

I can't tell why the first test failed because the "before 376832, after 376832, break 05800000" spam (may it rot in hell) corrupted the png data: URI.  The second test is just failing because the test image has rounded corners and the reference doesn't.  Is there some default style fennec is using that the test isn't turning off properly?

If so, this is likely reproducible with a fennec-desktop build.
Comment 6 Martijn Wargers [:mwargers] (gone per 2016-05-31 :-( ) 2011-10-07 13:54:23 PDT
Yeah, buttons are rounded on Fennec.
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/content.css#151
I guess that reftest needs fixing.
Comment 7 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-16 20:44:09 PDT
Created attachment 567384 [details] [diff] [review]
Patch (v1)

I totally deserved cjones slapping my wrists.  :(

But I need to restore my reputation here, so here's a patch to force the button's border to not be round.
Comment 8 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-16 20:45:16 PDT
Created attachment 567385 [details] [diff] [review]
Patch (v1)

Removed the unneeded comment in the reftest.list file.
Comment 9 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-16 20:46:16 PDT
https://tbpl.mozilla.org/?tree=Try&rev=cc3facb1432d
Comment 10 Mozilla RelEng Bot 2011-10-16 22:50:51 PDT
Try run for cc3facb1432d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=cc3facb1432d
Results (out of 2 total builds):
    success: 2
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-cc3facb1432d
Comment 11 Matt Brubeck (:mbrubeck) 2011-10-17 07:20:47 PDT
Comment on attachment 567385 [details] [diff] [review]
Patch (v1)

Note that you'll need to use "-u reftest-1" to get Android results on Try, because of bug 664857.
Comment 12 Mozilla RelEng Bot 2011-10-17 10:20:52 PDT
Try run for df2310393f24 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=df2310393f24
Results (out of 16 total builds):
    exception: 10
    success: 6
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-df2310393f24
Comment 13 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-17 13:16:14 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b1f937914ff
Comment 14 Marco Bonardo [::mak] 2011-10-18 05:35:11 PDT
https://hg.mozilla.org/mozilla-central/rev/2b1f937914ff

Note You need to log in before you can comment on or make changes to this bug.