Closed
Bug 692911
Opened 13 years ago
Closed 13 years ago
js::types::TypeConstraintSubsetBarrier::newType makes useless call to target->addType
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file, 1 obsolete file)
|
805 bytes,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
js::types::TypeConstraintSubsetBarrier::newType calls 'target->hasType(type)', and if that returns true, calls 'target->addType(cx, type)'. That second call should have no effect: it just adds to target a type that it already has.
The call to target->addType should be deleted.
The attached patch causes no regressions in jit-test and js-tests on Linux in DEBUG mode.
Attachment #565630 -
Flags: review?(bhackett1024)
|
Assignee | |
Comment 1•13 years ago
|
||
Trivial revision to patch, to clean things up a bit better.
Assignee: general → jimb
Attachment #565630 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #565630 -
Flags: review?(bhackett1024)
Attachment #565633 -
Flags: review?(bhackett1024)
|
||
Updated•13 years ago
|
Attachment #565630 -
Flags: review+
|
|
||
Updated•13 years ago
|
Attachment #565633 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [inbound]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/26ac81280f33
https://hg.mozilla.org/mozilla-central/rev/767693e248aa
were for bug 692991.
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•