Created attachment 565630 [details] [diff] [review] Delete useless call to target->addType in js::types::TypeConstraintSubsetBarrier::newType. js::types::TypeConstraintSubsetBarrier::newType calls 'target->hasType(type)', and if that returns true, calls 'target->addType(cx, type)'. That second call should have no effect: it just adds to target a type that it already has. The call to target->addType should be deleted. The attached patch causes no regressions in jit-test and js-tests on Linux in DEBUG mode.
Created attachment 565633 [details] [diff] [review] Delete useless call to target->addType in js::types::TypeConstraintSubsetBarrier::newType. Trivial revision to patch, to clean things up a bit better.
Attachment #565633 - Flags: review?(bhackett1024) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/26ac81280f33 https://hg.mozilla.org/mozilla-central/rev/767693e248aa were for bug 692991.
You need to log in before you can comment on or make changes to this bug.