check-sync-dirs.py tries to compare compiled python objects

RESOLVED FIXED in mozilla10

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: derf, Assigned: glandium)

Tracking

Trunk
mozilla10
ARM
Maemo
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
After a fresh checkout and build with the Fremantle SDK, I get, on my second build attempt:

TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
TEST-INFO | check-sync-dirs.py | file(s) found in:               /home/derf/src/mozilla/mozilla-central/js/src/config
TEST-INFO | check-sync-dirs.py | differ from their originals in: /home/derf/src/mozilla/mozilla-central/config
TEST-INFO | check-sync-dirs.py | differing file:                 ./expandlibs.pyo

I can work around this by copying the one in config on top of the one in js/src/config, but I'm pretty sure we shouldn't need to validate that .pyo files match exactly, as long as the corresponding .py files do.
I'm not sure what situations the .pyo would be legitimately different in a given tree. That said, you can fix this with a patch to:

http://mxr.mozilla.org/comm-central/source/mozilla/js/src/config/check-sync-exceptions

And if you also wish to patch the files for comm-central (Thunderbird, SeaMonkey) that test this (though comm doesn't cause build failure on it failing) you can do the same for the files referenced at:

http://mxr.mozilla.org/comm-central/find?text=&string=check-sync-exceptions
Created attachment 565643 [details] [diff] [review]
Ignore .pyo files in config|js/src/config synchro
Attachment #565643 - Flags: review?(ted.mielczarek)
Attachment #565643 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → mh+mozilla
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f6683b43abd
Whiteboard: [inbound]

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1f6683b43abd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.