Last Comment Bug 692918 - tries to compare compiled python objects
: tries to compare compiled python objects
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: ARM Maemo
-- normal (vote)
: mozilla10
Assigned To: Mike Hommey [:glandium]
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
  Show dependency treegraph
Reported: 2011-10-07 13:40 PDT by Timothy B. Terriberry (:derf)
Modified: 2011-10-28 04:40 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Ignore .pyo files in config|js/src/config synchro (543 bytes, patch)
2011-10-07 13:54 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description User image Timothy B. Terriberry (:derf) 2011-10-07 13:40:33 PDT
After a fresh checkout and build with the Fremantle SDK, I get, on my second build attempt:

TEST-UNEXPECTED-FAIL | | build file copies are not in sync
TEST-INFO | | file(s) found in:               /home/derf/src/mozilla/mozilla-central/js/src/config
TEST-INFO | | differ from their originals in: /home/derf/src/mozilla/mozilla-central/config
TEST-INFO | | differing file:                 ./expandlibs.pyo

I can work around this by copying the one in config on top of the one in js/src/config, but I'm pretty sure we shouldn't need to validate that .pyo files match exactly, as long as the corresponding .py files do.
Comment 1 User image Justin Wood (:Callek) 2011-10-07 13:51:57 PDT
I'm not sure what situations the .pyo would be legitimately different in a given tree. That said, you can fix this with a patch to:

And if you also wish to patch the files for comm-central (Thunderbird, SeaMonkey) that test this (though comm doesn't cause build failure on it failing) you can do the same for the files referenced at:
Comment 2 User image Mike Hommey [:glandium] 2011-10-07 13:54:56 PDT
Created attachment 565643 [details] [diff] [review]
Ignore .pyo files in config|js/src/config synchro
Comment 4 User image Ed Morley [:emorley] 2011-10-28 04:40:33 PDT

Note You need to log in before you can comment on or make changes to this bug.