Last Comment Bug 692918 - check-sync-dirs.py tries to compare compiled python objects
: check-sync-dirs.py tries to compare compiled python objects
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: ARM Maemo
: -- normal (vote)
: mozilla10
Assigned To: Mike Hommey [:glandium]
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-07 13:40 PDT by Timothy B. Terriberry (:derf)
Modified: 2011-10-28 04:40 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Ignore .pyo files in config|js/src/config synchro (543 bytes, patch)
2011-10-07 13:54 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Timothy B. Terriberry (:derf) 2011-10-07 13:40:33 PDT
After a fresh checkout and build with the Fremantle SDK, I get, on my second build attempt:

TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
TEST-INFO | check-sync-dirs.py | file(s) found in:               /home/derf/src/mozilla/mozilla-central/js/src/config
TEST-INFO | check-sync-dirs.py | differ from their originals in: /home/derf/src/mozilla/mozilla-central/config
TEST-INFO | check-sync-dirs.py | differing file:                 ./expandlibs.pyo

I can work around this by copying the one in config on top of the one in js/src/config, but I'm pretty sure we shouldn't need to validate that .pyo files match exactly, as long as the corresponding .py files do.
Comment 1 Justin Wood (:Callek) 2011-10-07 13:51:57 PDT
I'm not sure what situations the .pyo would be legitimately different in a given tree. That said, you can fix this with a patch to:

http://mxr.mozilla.org/comm-central/source/mozilla/js/src/config/check-sync-exceptions

And if you also wish to patch the files for comm-central (Thunderbird, SeaMonkey) that test this (though comm doesn't cause build failure on it failing) you can do the same for the files referenced at:

http://mxr.mozilla.org/comm-central/find?text=&string=check-sync-exceptions
Comment 2 Mike Hommey [:glandium] 2011-10-07 13:54:56 PDT
Created attachment 565643 [details] [diff] [review]
Ignore .pyo files in config|js/src/config synchro
Comment 4 Ed Morley [:emorley] 2011-10-28 04:40:33 PDT
https://hg.mozilla.org/mozilla-central/rev/1f6683b43abd

Note You need to log in before you can comment on or make changes to this bug.