Last Comment Bug 692919 - Need to somehow check to make sure that the list returned from GetChildLists doesn't have duplicates
: Need to somehow check to make sure that the list returned from GetChildLists ...
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: x86 Mac OS X
-- normal (vote)
: mozilla10
Assigned To: :Ehsan Akhgari
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2011-10-07 13:42 PDT by :Ehsan Akhgari
Modified: 2011-10-14 03:57 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (v1) (1.64 KB, patch)
2011-10-07 15:26 PDT, :Ehsan Akhgari
no flags Details | Diff | Splinter Review
Patch (v2) (1.09 KB, patch)
2011-10-12 08:19 PDT, :Ehsan Akhgari
mats: review+
Details | Diff | Splinter Review

Description User image :Ehsan Akhgari 2011-10-07 13:42:51 PDT
In order to prevent the likes of bug 691824 in the future.  Where do you guys think it would make sense for that check to live?  (Anything I can think of involves adding it to multiple places)
Comment 1 User image Mats Palmgren (:mats) 2011-10-07 14:15:04 PDT
After GetChildLists here should cover most consumers I think:
Comment 2 User image :Ehsan Akhgari 2011-10-07 15:26:52 PDT
Created attachment 565673 [details] [diff] [review]
Patch (v1)
Comment 3 User image :Ehsan Akhgari 2011-10-07 15:27:42 PDT
Comment 4 User image Mats Palmgren (:mats) 2011-10-07 16:42:05 PDT
Comment on attachment 565673 [details] [diff] [review]
Patch (v1)

Couldn't you just loop through mLists and build a FrameChildListIDs
using |= mID after asserting you haven't seen it yet with !Contains(mID)
Comment 5 User image :Ehsan Akhgari 2011-10-12 08:19:19 PDT
Created attachment 566536 [details] [diff] [review]
Patch (v2)

Comment 6 User image Mats Palmgren (:mats) 2011-10-12 15:48:24 PDT
Comment on attachment 566536 [details] [diff] [review]
Patch (v2)

Let's take the opportunity to add a constructor for the empty set:
  FrameChildListIDs() : mIDs(0) {}

I think it's useful to have in the public part of the API.
(use it for 'ids')

Comment 8 User image Ed Morley [:emorley] 2011-10-14 03:57:47 PDT

Note You need to log in before you can comment on or make changes to this bug.