692919 - Need to somehow check to make sure that the list returned from GetChildLists doesn't have duplicates

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[(no longer active)]

In order to prevent the likes of bug 691824 in the future.  Where do you guys think it would make sense for that check to live?  (Anything I can think of involves adding it to multiple places)

Comment 1

[Mats Palmgren (inactive)]

After GetChildLists here should cover most consumers I think:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/FrameChildList.cpp#49

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

http://tbpl.mozilla.org/?tree=Try&rev=a2a41ffd3ba3

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 565673 [details] [diff] [review]
Patch (v1)

Couldn't you just loop through mLists and build a FrameChildListIDs
using |= mID after asserting you haven't seen it yet with !Contains(mID)

Comment 5

[(no longer active)]

Attachment: Patch (v2)

Done.

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 566536 [details] [diff] [review]
Patch (v2)

Let's take the opportunity to add a constructor for the empty set:
  FrameChildListIDs() : mIDs(0) {}

I think it's useful to have in the public part of the API.
(use it for 'ids')

r=mats

Comment 7

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a375341a2a07

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a375341a2a07