Last Comment Bug 692978 - Split up lookupProperty into name/element/special forms
: Split up lookupProperty into name/element/special forms
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-07 15:53 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-10-15 05:21 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (45.86 KB, patch)
2011-10-07 15:53 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
bhackett1024: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-10-07 15:53:49 PDT
Created attachment 565678 [details] [diff] [review]
Patch

There are a lot of places in here where pushing the PropertyName distinction lower down in the source (into the scanner, parser, emitter, etc.) would help with de-genericization.  I'm working on patches doing that, but they're atop this, and they'll be separate bugs.
Comment 1 Jeff Walden [:Waldo] (remove +bmo to email) 2011-10-14 11:34:50 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/09242b2aa989

Second time's the charm, after a first time backout (this patch wasn't the baddie, tho).
Comment 2 Ed Morley [:emorley] 2011-10-15 05:21:36 PDT
https://hg.mozilla.org/mozilla-central/rev/09242b2aa989

Note You need to log in before you can comment on or make changes to this bug.