The default bug view has changed. See this FAQ.

"Assertion failure: cannot reenter" in Proxy::objectClassIs

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jesse Ruderman, Assigned: luke)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla10
x86_64
Windows 7
assertion, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 565772 [details]
testcase (asserts fatally on 25% of launches)

On about 25% of launches of Firefox, this testcase triggers:
  Assertion failure: cannot reenter, at js/src/jsproxy.cpp:880

This assertion was added in:
  http://hg.mozilla.org/mozilla-central/rev/b626aecfddf7
  Bug 683361 - Fix part 6: add and call Proxy::objectClassIs (r=waldo)
(Reporter)

Comment 1

6 years ago
Related to bug 618906?
(Reporter)

Comment 2

6 years ago
Created attachment 565773 [details]
top of the stack
(Assignee)

Comment 3

6 years ago
Jesse, can you still reproduce the crash?  Also, what platform?

Regardless, this shouldn't be an infinite recursion; it isn't in the shell...
(Assignee)

Comment 4

6 years ago
Ah, so the infinite recursion is happening outside the engine when XPConnect tries to convert the cyclic object to nsISupports and the assert is bogus and can be removed.  I added the assert for visual symmetry with the other Proxy functions but it clearly has false negatives.
(Assignee)

Comment 5

6 years ago
Created attachment 565972 [details] [diff] [review]
rm assert
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #565972 - Flags: review?(jwalden+bmo)
Attachment #565972 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c60fe2051fe
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/6c60fe2051fe
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.