Created attachment 565772 [details] testcase (asserts fatally on 25% of launches) On about 25% of launches of Firefox, this testcase triggers: Assertion failure: cannot reenter, at js/src/jsproxy.cpp:880 This assertion was added in: http://hg.mozilla.org/mozilla-central/rev/b626aecfddf7 Bug 683361 - Fix part 6: add and call Proxy::objectClassIs (r=waldo)
|
(Reporter) | |
Comment 1•6 years ago
|
||
Related to bug 618906?
|
|
(Reporter) | |
Comment 2•6 years ago
|
||
Created attachment 565773 [details]
top of the stack
|
(Assignee) | |
Comment 3•6 years ago
|
||
Jesse, can you still reproduce the crash? Also, what platform? Regardless, this shouldn't be an infinite recursion; it isn't in the shell...
|
|
(Assignee) | |
Comment 4•6 years ago
|
||
Ah, so the infinite recursion is happening outside the engine when XPConnect tries to convert the cyclic object to nsISupports and the assert is bogus and can be removed. I added the assert for visual symmetry with the other Proxy functions but it clearly has false negatives.
|
|
(Assignee) | |
Comment 5•6 years ago
|
||
Created attachment 565972 [details] [diff] [review] rm assert
|
||
Updated•6 years ago
|
||
|
|
(Assignee) | |
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c60fe2051fe
|
||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6c60fe2051fe
Description
•