Closed Bug 693124 Opened 10 years ago Closed 10 years ago

"Assertion failure: cannot reenter" in Proxy::objectClassIs

Categories

(Core :: JavaScript Engine, defect)

x86_64
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jruderman, Assigned: luke)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

On about 25% of launches of Firefox, this testcase triggers:
  Assertion failure: cannot reenter, at js/src/jsproxy.cpp:880

This assertion was added in:
  http://hg.mozilla.org/mozilla-central/rev/b626aecfddf7
  Bug 683361 - Fix part 6: add and call Proxy::objectClassIs (r=waldo)
Related to bug 618906?
Attached file top of the stack
Jesse, can you still reproduce the crash?  Also, what platform?

Regardless, this shouldn't be an infinite recursion; it isn't in the shell...
Ah, so the infinite recursion is happening outside the engine when XPConnect tries to convert the cyclic object to nsISupports and the assert is bogus and can be removed.  I added the assert for visual symmetry with the other Proxy functions but it clearly has false negatives.
Attached patch rm assertSplinter Review
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #565972 - Flags: review?(jwalden+bmo)
Attachment #565972 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/6c60fe2051fe
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.