Move all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache, and then merge the classes

RESOLVED FIXED in mozilla13

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: ewong)

Tracking

unspecified
mozilla13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=khuey][lang=c++], URL)

Attachments

(1 attachment, 6 obsolete attachments)

My understanding is that the long term plan is to wrapper cache everything.  This moves us further down that path.
This might be a good second or third bug for somebody who is interested in poking around the DOM.
Whiteboard: [mentor=khuey][lang=c++]

Updated

6 years ago
(Assignee)

Comment 2

6 years ago
Created attachment 584367 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes.
Attachment #584367 - Flags: review?(khuey)
(Assignee)

Comment 3

6 years ago
Created attachment 584538 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and merged the classes.

Over irc, khuey suggested I move the subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and then merge the two classes.
Assignee: nobody → ewong
Attachment #584367 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #584367 - Flags: review?(khuey)
Attachment #584538 - Flags: review?(khuey)
Comment on attachment 584538 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and merged the classes.

Looks pretty good to me.  Going to toss it over to smaug for the official review though, since he owns event handling.
Attachment #584538 - Flags: review?(khuey)
Attachment #584538 - Flags: review?(bugs)
Attachment #584538 - Flags: feedback+

Comment 5

6 years ago
Comment on attachment 584538 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetWrapperCache to nsDOMEventTargetHelper and merged the classes.

Looks ok, but I think there has been some changes to this code so could you
update the patch.
Attachment #584538 - Flags: review?(bugs) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 586791 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v2)
Attachment #584538 - Attachment is obsolete: true
Attachment #586791 - Flags: review?(bugs)
(Assignee)

Updated

6 years ago
Attachment #586791 - Flags: review?(bugs)
(Assignee)

Comment 7

6 years ago
Created attachment 586987 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v3)
Attachment #586791 - Attachment is obsolete: true
Attachment #586987 - Flags: review?(bugs)

Comment 8

6 years ago
Comment on attachment 586987 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v3)

This makes the hg annotation messy. Could you just update the previous
patch to contain the changes done to the nsDOMEventTargetWrapperCache
so that the code is copied to nsDOMEventTargetHelper
Attachment #586987 - Flags: review?(bugs) → review-
(Assignee)

Comment 9

6 years ago
Created attachment 588007 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v4)
Attachment #586987 - Attachment is obsolete: true
Attachment #588007 - Flags: review?(bugs)
Comment on attachment 588007 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v4)

You're not moving the cycle collection related parts for *Cache to the
*Helper.
Attachment #588007 - Flags: review?(bugs) → review-
(Assignee)

Comment 11

6 years ago
Created attachment 594063 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v5)
Attachment #588007 - Attachment is obsolete: true
Attachment #594063 - Flags: review?(bugs)
(Assignee)

Comment 12

6 years ago
Created attachment 594080 [details] [diff] [review]
Moved all subclasses of nsDOMEventTargetHelper to nsDOMEventTargetWrapperCache and then merge the classes. (v6)

Unbitrotted patch.
Attachment #594063 - Attachment is obsolete: true
Attachment #594063 - Flags: review?(bugs)
Attachment #594080 - Flags: review?(bugs)

Updated

6 years ago
Attachment #594080 - Flags: review?(bugs) → review+
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla13
Blocks: 725312
https://hg.mozilla.org/mozilla-central/rev/bc6a70cdc0e7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Um, did this cause leaks. I'm seeing lots of XHR objects in my CC graph.
Though, could be also this horrible network connection and tons of tbpl tabs open.
Investigating.
You need to log in before you can comment on or make changes to this bug.