Closed Bug 693186 Opened 11 years ago Closed 11 years ago

dump_masters.py should be able to represent WithProperties better.

Categories

(Release Engineering :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
It dawned on me during my use of dump_masters.py that if a WithProperties changes, we won't report on it here. Though WithProperties is comparable so will still change stuff.

I am cheating a bit here with the implementation by directly extending the class, but it does work.

Let me know if you need example output from my SeaMonkey master with this applied.
Attachment #565817 - Flags: review?(catlee)
Comment on attachment 565817 [details] [diff] [review]
v1

monkeypatching FTW!
Attachment #565817 - Flags: review?(catlee) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.