Closed
Bug 693186
Opened 14 years ago
Closed 14 years ago
dump_masters.py should be able to represent WithProperties better.
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
Details
Attachments
(1 file)
|
775 bytes,
patch
|
catlee
:
review+
Callek
:
checked-in+
|
Details | Diff | Splinter Review |
It dawned on me during my use of dump_masters.py that if a WithProperties changes, we won't report on it here. Though WithProperties is comparable so will still change stuff.
I am cheating a bit here with the implementation by directly extending the class, but it does work.
Let me know if you need example output from my SeaMonkey master with this applied.
Attachment #565817 -
Flags: review?(catlee)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 565817 [details] [diff] [review]
v1
monkeypatching FTW!
Attachment #565817 -
Flags: review?(catlee) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 565817 [details] [diff] [review]
v1
http://hg.mozilla.org/build/braindump/rev/54ad34de7783
Attachment #565817 -
Attachment is patch: true
Attachment #565817 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•