693282 - BasicShadowableThebesLayer leaking backBuffers

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

Found that in 690469 I dropped 
    BasicManager()->DestroyedThebesBuffer(BasicManager()->Hold(this),
                                          mBackBuffer);
which was collecting dying buffers and deallocating it.

Looks like that part need to be moved back, otherwise we are leaking thebes buffers

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Collect and drop dying thebes backBuffers

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This fix looks OK, but why wasn't the leak caught by any of our tests?  Were buffers actually leaking during reftest-ipc but not being caught, or do none of our tests exercise the path that was leading to a leak?  We need to make sure this doesn't happen again.

Comment 3

[Oleg Romashin (:romaxa)]

yep, that is interesting question...
that leak is very easily visible in about:memory reporter.... but reason is that we don't run IPC-reftests on debug linux builds... only on opt builds... that is why we don't run leak enabled test-run...

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Sigh.  Filed bug 693478.

Comment 5

[Oleg Romashin (:romaxa)]

This patch need to be landed in couple with patch from bug 690469
in order 
1-st bug 690469, second 693282

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd148629d7e7

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/cd148629d7e7