Last Comment Bug 693282 - BasicShadowableThebesLayer leaking backBuffers
: BasicShadowableThebesLayer leaking backBuffers
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla10
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 690469
  Show dependency treegraph
 
Reported: 2011-10-10 05:15 PDT by Oleg Romashin (:romaxa)
Modified: 2011-10-11 02:38 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Collect and drop dying thebes backBuffers (3.05 KB, patch)
2011-10-10 05:16 PDT, Oleg Romashin (:romaxa)
cjones.bugs: review+
Details | Diff | Review

Description Oleg Romashin (:romaxa) 2011-10-10 05:15:10 PDT
Found that in 690469 I dropped 
    BasicManager()->DestroyedThebesBuffer(BasicManager()->Hold(this),
                                          mBackBuffer);
which was collecting dying buffers and deallocating it.

Looks like that part need to be moved back, otherwise we are leaking thebes buffers
Comment 1 Oleg Romashin (:romaxa) 2011-10-10 05:16:59 PDT
Created attachment 565907 [details] [diff] [review]
Collect and drop dying thebes backBuffers
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-10-10 15:33:31 PDT
This fix looks OK, but why wasn't the leak caught by any of our tests?  Were buffers actually leaking during reftest-ipc but not being caught, or do none of our tests exercise the path that was leading to a leak?  We need to make sure this doesn't happen again.
Comment 3 Oleg Romashin (:romaxa) 2011-10-10 15:44:42 PDT
yep, that is interesting question...
that leak is very easily visible in about:memory reporter.... but reason is that we don't run IPC-reftests on debug linux builds... only on opt builds... that is why we don't run leak enabled test-run...
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-10-10 16:07:09 PDT
Sigh.  Filed bug 693478.
Comment 5 Oleg Romashin (:romaxa) 2011-10-10 16:13:41 PDT
This patch need to be landed in couple with patch from bug 690469
in order 
1-st bug 690469, second 693282
Comment 7 Marco Bonardo [::mak] 2011-10-11 02:38:42 PDT
https://hg.mozilla.org/mozilla-central/rev/cd148629d7e7

Note You need to log in before you can comment on or make changes to this bug.