Last Comment Bug 693283 - cannot detect endian of Android x86 on libsydney
: cannot detect endian of Android x86 on libsydney
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86 Android
-- normal (vote)
: mozilla10
Assigned To: Makoto Kato [:m_kato]
: Maire Reavy [:mreavy] Please needinfo me
Depends on:
  Show dependency treegraph
Reported: 2011-10-10 05:21 PDT by Makoto Kato [:m_kato]
Modified: 2011-10-14 03:47 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (659 bytes, patch)
2011-10-10 08:44 PDT, Makoto Kato [:m_kato]
kinetik: review+
Details | Diff | Splinter Review

Description User image Makoto Kato [:m_kato] 2011-10-10 05:21:52 PDT
On Android/arm, endian define is by including sys/types.h, but it is arm only.  We should include sys/endian.h for non-arm android.
Comment 1 User image Makoto Kato [:m_kato] 2011-10-10 08:44:30 PDT
Created attachment 565947 [details] [diff] [review]
Comment 2 User image Matthew Gregan [:kinetik] 2011-10-10 16:27:18 PDT
Did you want someone to review this?  I can't test this change right now, but it looks fine to me.
Comment 3 User image Makoto Kato [:m_kato] 2011-10-12 23:00:35 PDT
Comment on attachment 565947 [details] [diff] [review]

I already tested on my android x86 target.
Comment 5 User image Ed Morley [:emorley] 2011-10-14 03:47:43 PDT

Note You need to log in before you can comment on or make changes to this bug.