Last Comment Bug 693283 - cannot detect endian of Android x86 on libsydney
: cannot detect endian of Android x86 on libsydney
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86 Android
: -- normal (vote)
: mozilla10
Assigned To: Makoto Kato [:m_kato] (PTO 9/22-9/25)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-10 05:21 PDT by Makoto Kato [:m_kato] (PTO 9/22-9/25)
Modified: 2011-10-14 03:47 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (659 bytes, patch)
2011-10-10 08:44 PDT, Makoto Kato [:m_kato] (PTO 9/22-9/25)
kinetik: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] (PTO 9/22-9/25) 2011-10-10 05:21:52 PDT
On Android/arm, endian define is by including sys/types.h, but it is arm only.  We should include sys/endian.h for non-arm android.
Comment 1 Makoto Kato [:m_kato] (PTO 9/22-9/25) 2011-10-10 08:44:30 PDT
Created attachment 565947 [details] [diff] [review]
fix
Comment 2 Matthew Gregan [:kinetik] 2011-10-10 16:27:18 PDT
Did you want someone to review this?  I can't test this change right now, but it looks fine to me.
Comment 3 Makoto Kato [:m_kato] (PTO 9/22-9/25) 2011-10-12 23:00:35 PDT
Comment on attachment 565947 [details] [diff] [review]
fix

I already tested on my android x86 target.
Comment 4 Makoto Kato [:m_kato] (PTO 9/22-9/25) 2011-10-13 20:29:16 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d615b5d42d8
Comment 5 Ed Morley [:emorley] 2011-10-14 03:47:43 PDT
https://hg.mozilla.org/mozilla-central/rev/4d615b5d42d8

Note You need to log in before you can comment on or make changes to this bug.