float patch queue does not compile on linux32

VERIFIED FIXED in Q2 12 - Cyril

Status

defect
P2
normal
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: brbaker, Assigned: virgilp)

Tracking

unspecified
Q2 12 - Cyril
x86
Linux
Dependency tree / graph
Bug Flags:
flashplayer-injection +
flashplayer-qrb +
flashplayer-bug -
flashplayer-triage +

Details

Reporter

Description

8 years ago
Current patch queue (170:b34841678e73) does not compile on linux 32. 

In file included from ../platform/unix/unix-platform.h:163,
                 from ../VMPI/VMPI.h:85,
                 from ../VMPI/PosixSpecificUtils.cpp:41:
/usr/local/lib/gcc/x86_64-unknown-linux-gnu/4.3.6/include/xmmintrin.h:35:3: error: #error "SSE instruction set not enabled"

The sse instruction set must be enabled for the compiler by adding the gcc switch -msse 


--- a/configure.py	Fri Oct 07 08:18:00 2011 -0400
+++ b/configure.py	Mon Oct 10 10:19:11 2011 -0400
@@ -137,7 +137,7 @@
 APP_CPPFLAGS = "-DAVMSHELL_BUILD "
 APP_CXXFLAGS = ""
 APP_CFLAGS = ""
-OPT_CXXFLAGS = "-O3 "
+OPT_CXXFLAGS = "-O3 -msse"
 OPT_CPPFLAGS = ""
 DEBUG_CPPFLAGS = "-DDEBUG -D_DEBUG "
 DEBUG_CXXFLAGS = ""

However once you get the compiler past this issue you run into the following error:


In file included from ../core/../nanojit/nanojit.h:364,
                 from ../core/LirHelper.h:45,
                 from ../core/CodegenLIR.h:45,
                 from ../core/AvmCore.cpp:46:
../core/../nanojit/Containers.h: In function ‘bool nanojit::keysEqual(K, K) [with K = float __vector__]’:
../core/../nanojit/Containers.h:260: error: ‘_mm_castps_si128’ was not declared in this scope
../core/../nanojit/Containers.h:260: error: ‘_mm_movemask_epi8’ was not declared in this scope
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Flags: flashplayer-bug-
Reporter

Comment 1

8 years ago
The switch really should be -msse2 I believe, which results in a linking error:


shell/../extensions/SelftestExec.o: In function `avmplus::ST_vmpi_threads::CASTest::workerThreadEntry()':
SelftestExec.cpp:(.text._ZN7avmplus15ST_vmpi_threads7CASTest17workerThreadEntryEv[avmplus::ST_vmpi_threads::CASTest::workerThreadEntry()]+0x32): undefined reference to `__sync_bool_compare_and_swap_4'
Reporter

Comment 2

8 years ago
This error is probably a little more interesting (compiled with selftests disabled)

./libvmbase.a(VMThread.o): In function `vmbase::VMThread::VMThread(vmbase::Runnable*)':
VMThread.cpp:(.text+0xb43): undefined reference to `__sync_add_and_fetch_4'
./libvmbase.a(VMThread.o): In function `vmbase::VMThread::VMThread(vmbase::Runnable*)':
VMThread.cpp:(.text+0xc63): undefined reference to `__sync_add_and_fetch_4'
./libvmbase.a(VMThread.o): In function `vmbase::VMThread::VMThread()':
VMThread.cpp:(.text+0xf00): undefined reference to `__sync_add_and_fetch_4'
./libvmbase.a(VMThread.o): In function `vmbase::VMThread::VMThread()':
VMThread.cpp:(.text+0x1020): undefined reference to `__sync_add_and_fetch_4'
Reporter

Comment 3

8 years ago
Seems as though when compiling linux32 on a 64bit platform we need to include the following gcc/g++ switches:

-march=i686 -mss2e
Reporter

Comment 4

8 years ago
This currently is not blocking the autobuild system as I have tweaked the jenkins config to pass these 2 switches into gcc/g++

Updated

8 years ago
Flags: flashplayer-qrb?
Flags: flashplayer-qrb+
Flags: flashplayer-injection+
Priority: -- → P2
Target Milestone: --- → Q2 12 - Cyril
Reporter

Comment 5

8 years ago
This is resolved in bug-615489.floatClass.build.diff (184:fde0c16e4d0a)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Reporter

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.