Closed Bug 693301 Opened 8 years ago Closed 8 years ago

Remove ConstructProxyObject

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
We can construct the outer window proxy from WrapObject.
Attachment #565936 - Flags: review?(mrbkap)
Comment on attachment 565936 [details] [diff] [review]
v1

Review of attachment 565936 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.h
@@ +302,5 @@
> +  // nsWrapperCache
> +  JSObject *WrapObject(JSContext *cx, XPCWrappedNativeScope *scope,
> +                       bool *triedToWrap)
> +  {
> +    *triedToWrap = IsOuterWindow();

I think you should be able to assert that this is true since we don't QI to nsWrapperCache for inner windows.
Attachment #565936 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/82fd332d288a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.