Closed
Bug 693301
Opened 13 years ago
Closed 13 years ago
Remove ConstructProxyObject
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: peterv, Assigned: peterv)
Details
Attachments
(1 file)
|
5.56 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
We can construct the outer window proxy from WrapObject.
Attachment #565936 -
Flags: review?(mrbkap)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 565936 [details] [diff] [review]
v1
Review of attachment 565936 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/nsGlobalWindow.h
@@ +302,5 @@
> + // nsWrapperCache
> + JSObject *WrapObject(JSContext *cx, XPCWrappedNativeScope *scope,
> + bool *triedToWrap)
> + {
> + *triedToWrap = IsOuterWindow();
I think you should be able to assert that this is true since we don't QI to nsWrapperCache for inner windows.
Attachment #565936 -
Flags: review?(mrbkap) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Target Milestone: --- → mozilla10
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•