693413 - Service.startOver resets Status.sync too late, prefs pane flickers

Status: RESOLVED FIXED

Description

[Philipp von Weitershausen [:philikon]]

This is a tiny regression from bug 691663 that I just found: If you "Unlink This Device" in the Sync prefs pane, the prefs pane flickers and goes back to displaying the page for when you have Sync set up (which is wrong). I believe the reason for that is because we reset Status.sync too late in Service.startOver.

Fix incoming.

Comment 1

[Philipp von Weitershausen [:philikon]]

Created attachment 566093 [details] [diff] [review]
v1

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 566093 [details] [diff] [review]
v1

Review of attachment 566093 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/sync/tests/unit/test_service_startOver.js
@@ +37,5 @@
> +
> +  // Verify set up.
> +  do_check_eq(Status.checkSetup(), STATUS_OK);
> +
> +  // Verify state that the observer sees

'.'

Comment 3

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/services/services-central/rev/0ab95b85d06e

Comment 4

[Philipp von Weitershausen [:philikon]]

STRs for QA:

- Choose a profile that has Sync set up (or set up Sync)
- Click on "Unlink This Device" in the Sync prefpane
- ensure the prefpane shows the "Set up Sync" and "Pair a Device" links

Please note: this regression was introduced by bug 691663. "Unlink This Device" is an essential feature of Sync, much like the Sync setup wizard, and should be part of every smoketest.

Comment 5

[Philipp von Weitershausen [:philikon]]

Comment on attachment 566093 [details] [diff] [review]
v1

Requesting approval for Beta and Aurora since bug 691663 which caused this tiny regression was landed in those places last week. I apologize for causing that and made sure to follow up with QA since the regression should really have been found when running smoketests against bug 691663 (which we did before landing in Aurora and Beta).

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111011 Firefox/10.0a1
Mozilla/5.0 (Windows NT 5.1; rv:10.0a1) Gecko/20111011 Firefox/10.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a1) Gecko/20111011 Firefox/10.0a1
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0a1) Gecko/20111011 Firefox/10.0a1

ID: 20111011093957

Verified the fix on the above builds.
After unlinking a device, the "Set Up Sync" and "Pair a device" pane is shown and no flickering observed.

Comment 7

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/0ab95b85d06e

Comment 8

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0cb1870e32d2

Comment 9

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/releases/mozilla-beta/rev/446adf5e2672

Comment 10

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (X11; Linux i686 on x86_64; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0

Verified on 9beta5 using the steps from comment #4 and no flicker was observed; device unlinked successfully