Last Comment Bug 693425 - test file layout/forms/test/bug536567_subframe.html isn't used
: test file layout/forms/test/bug536567_subframe.html isn't used
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Layout: Form Controls (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Joel Maher (:jmaher)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-10 13:48 PDT by Joel Maher (:jmaher)
Modified: 2011-10-15 05:41 PDT (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
move 536567_subframe file to the chrome folder (1.0) (2.04 KB, patch)
2011-10-11 11:33 PDT, Joel Maher (:jmaher)
ehsan: review+
Details | Diff | Review

Description Joel Maher (:jmaher) 2011-10-10 13:48:30 PDT
I found this file sitting around with no test to drive it.  Either we accidentally removed the test file or we forgot to remove this subframe file.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-10-10 13:51:29 PDT
It's used by test_bug536567.html in the same directory.
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-10-10 13:53:14 PDT
Actually, did
https://hg.mozilla.org/mozilla-central/rev/aa76da2d163e
break the test by not also moving the subframe document into the chrome list?
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2011-10-10 13:54:19 PDT
ah, bug 614151 comment 15 says that's intentional, I think.
Comment 4 Joel Maher (:jmaher) 2011-10-10 18:24:45 PDT
can we put a comment in that test file?  It is really confusing as it is sitting in the mochitest plain files.  I don't have access to bug 614151, but by looking at the changeset that moved the test file I don't see a comment indicating why we left the subframe in mochitest-plain.

We  can move the _subframe file into the chrome directory and access it via:
http://mochi.test:8888/chrome/layout/forms/test/bug536567_subframe.html
Comment 5 Boris Zbarsky [:bz] 2011-10-10 18:48:59 PDT
Bug 614151 comment 15 says:

  The subframe file should be accessible through http, and therefore should not be
  packaged in the chrome package. 

If that's not the case, great.
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2011-10-11 09:00:12 PDT
Yeah, I think the purpose of that test is to be able to access that page across multiple domains (see http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug536567.html?force=1#122 and http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug536567.html?force=1#50).  But I think comment 4 is right on, we should do that.

Joel, can you please take care of this?  :-)
Comment 7 Joel Maher (:jmaher) 2011-10-11 11:33:59 PDT
Created attachment 566281 [details] [diff] [review]
move 536567_subframe file to the chrome folder (1.0)

tested locally and looking good on try server so far!
Comment 9 Ed Morley [:emorley] 2011-10-15 05:41:26 PDT
https://hg.mozilla.org/mozilla-central/rev/77f71b03dfe6

Note You need to log in before you can comment on or make changes to this bug.