693425 - test file layout/forms/test/bug536567_subframe.html isn't used

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

I found this file sitting around with no test to drive it.  Either we accidentally removed the test file or we forgot to remove this subframe file.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's used by test_bug536567.html in the same directory.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, did
https://hg.mozilla.org/mozilla-central/rev/aa76da2d163e
break the test by not also moving the subframe document into the chrome list?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

ah, bug 614151 comment 15 says that's intentional, I think.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

can we put a comment in that test file?  It is really confusing as it is sitting in the mochitest plain files.  I don't have access to bug 614151, but by looking at the changeset that moved the test file I don't see a comment indicating why we left the subframe in mochitest-plain.

We  can move the _subframe file into the chrome directory and access it via:
http://mochi.test:8888/chrome/layout/forms/test/bug536567_subframe.html

Comment 5

[Boris Zbarsky [:bzbarsky]]

Bug 614151 comment 15 says:

  The subframe file should be accessible through http, and therefore should not be
  packaged in the chrome package. 

If that's not the case, great.

Comment 6

[(no longer active)]

Yeah, I think the purpose of that test is to be able to access that page across multiple domains (see http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug536567.html?force=1#122 and http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug536567.html?force=1#50).  But I think comment 4 is right on, we should do that.

Joel, can you please take care of this?  :-)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Attachment: move 536567_subframe file to the chrome folder (1.0)

tested locally and looking good on try server so far!

Comment 8

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77f71b03dfe6

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/77f71b03dfe6