Closed Bug 693425 Opened 8 years ago Closed 8 years ago

test file layout/forms/test/bug536567_subframe.html isn't used

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jmaher, Assigned: jmaher)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

I found this file sitting around with no test to drive it.  Either we accidentally removed the test file or we forgot to remove this subframe file.
It's used by test_bug536567.html in the same directory.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Actually, did
https://hg.mozilla.org/mozilla-central/rev/aa76da2d163e
break the test by not also moving the subframe document into the chrome list?
ah, bug 614151 comment 15 says that's intentional, I think.
can we put a comment in that test file?  It is really confusing as it is sitting in the mochitest plain files.  I don't have access to bug 614151, but by looking at the changeset that moved the test file I don't see a comment indicating why we left the subframe in mochitest-plain.

We  can move the _subframe file into the chrome directory and access it via:
http://mochi.test:8888/chrome/layout/forms/test/bug536567_subframe.html
Bug 614151 comment 15 says:

  The subframe file should be accessible through http, and therefore should not be
  packaged in the chrome package. 

If that's not the case, great.
Yeah, I think the purpose of that test is to be able to access that page across multiple domains (see http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug536567.html?force=1#122 and http://mxr.mozilla.org/mozilla-central/source/layout/forms/test/test_bug536567.html?force=1#50).  But I think comment 4 is right on, we should do that.

Joel, can you please take care of this?  :-)
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
tested locally and looking good on try server so far!
Assignee: nobody → jmaher
Status: REOPENED → ASSIGNED
Attachment #566281 - Flags: review?(ehsan)
Attachment #566281 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/77f71b03dfe6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.