Closed Bug 693454 Opened 9 years ago Closed 3 years ago

Create unified infrastructure for XPCWrappedNative::CallMethod and XPCWrappedJSClass::CallMethod

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED INACTIVE

People

(Reporter: bholley, Unassigned)

References

(Blocks 1 open bug)

Details

There are two pressing problems with maintainability in XPConnect:l

1 - XPCWrappedJSClass is still a mess, and hasn't benefited from any of the cleanup that has gone on in XPCWrappedNative.

2 - There are lots of copy-pasted methods and blocks of code between the two files.


The structure of CallMethod is quite similar between the two files. So I think we could benefit from a single unified abstract superclass to XPCWrappedNative::CallMethodHelper that handles common tasks and contains common utility methods. The corresponding implementations can then extend the common code with static inline inheritance.
I'm now busy enough with more important things that I don't see myself working on this any time in the foreseeable future. Unassigning.
Assignee: bobbyholley+bmo → nobody
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.