Closed Bug 693565 Opened 13 years ago Closed 11 years ago

try server -p argument checking

Categories

(Release Engineering :: General, enhancement, P5)

enhancement

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 591688

People

(Reporter: joey, Unassigned)

References

Details

(Keywords: trychooser, Whiteboard: [tryserver])

The try server does not seem to be performing sanity checks on arguments passed, at least not for -p.

I have a shell script setup for handling try server submissions with varying arguments.  This morning I happened to notice one of the platform arguments specified was invalid -- 'lnx86' rather than 'linux'.  The typo was silently ignored and I happened to notice this morning that only two logs were generated:


https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=59212f37773b

59212f37773b
Joey Armstrong – try: -e -p lnx86,macosx64,win64 -b o -t none -u none

  OS X64 opt
  Win64 opt



Try submissions should fail early and reject the submission outright when invalid parameters are detected.  Otherwise people will generate a subset of results or will have to terminate a running job and resubmit with missing info.
Priority: -- → P3
Whiteboard: [tryserver]
This is one of the reasons for the tools that exist: http://people.mozilla.org/~lsblakk/trychooser/ and https://github.com/pbiggar/trychooser to help people compose their syntax properly. Both those tools are usually an accurate reflection of what is available to try.

The way the try_parser works doesn't easily allow for user feedback at the push level and the parser itself is not implemented in the hook that merely checks for the existence of try syntax (http://hg.mozilla.org/hgcustom/hghooks/file/194680ffc158/mozhghooks/try_mandatory.py).

This is a valid concern but I see it as an enhancement request so I'm updating to reflect that, and full-disclosure: try_enhancements are pretty much waiting for some a contributor to come along and show them some love.
Severity: normal → enhancement
Priority: P3 → P5
If the try: push command specified an invalid parameter, would it be possible/
feasible to do the command-line syntax and if something is wrong with the
syntax (i.e. invalid platform), it doesn't do anything but send an email to
the 'pusher' that the syntax was invalid.  

Or should it continue with the try even with the invalid syntax? i.e.

Also, is this bug a dupe of bug #591688?
Keywords: trychooser
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.