Last Comment Bug 693595 - Missing classinfo for WebGLExtensionStandardDerivatives in a build without WebGL
: Missing classinfo for WebGLExtensionStandardDerivatives in a build without WebGL
Status: RESOLVED FIXED
[iOS]
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Ted Mielczarek [:ted.mielczarek]
:
Mentors:
Depends on:
Blocks: 684853
  Show dependency treegraph
 
Reported: 2011-10-11 07:50 PDT by Ted Mielczarek [:ted.mielczarek]
Modified: 2011-11-09 05:20 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add WebGLExtensionStandardDerivatives to WebGLContextNotSupported (917 bytes, patch)
2011-10-11 07:53 PDT, Ted Mielczarek [:ted.mielczarek]
jacob.benoit.1: review+
Details | Diff | Splinter Review

Description Ted Mielczarek [:ted.mielczarek] 2011-10-11 07:50:18 PDT
bug 684853 landed this new class, but didn't add the classinfo to WebGLContextNotSupported, so a build on a platform without WebGL breaks. Pretty trivial patch, I'll attach in a minute.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2011-10-11 07:53:54 PDT
Created attachment 566221 [details] [diff] [review]
Add WebGLExtensionStandardDerivatives to WebGLContextNotSupported

This patch just adds the classinfo definition to WebGLContextNotSupported.cpp.
Comment 2 Benoit Jacob [:bjacob] (mostly away) 2011-10-17 20:02:04 PDT
Comment on attachment 566221 [details] [diff] [review]
Add WebGLExtensionStandardDerivatives to WebGLContextNotSupported

Ah thanks. Sorry I didn't catch that.
Comment 3 Ted Mielczarek [:ted.mielczarek] 2011-11-08 07:57:01 PST
http://hg.mozilla.org/integration/mozilla-inbound/rev/13397d5e7dcd
Comment 4 Marco Bonardo [::mak] 2011-11-09 05:20:15 PST
https://hg.mozilla.org/mozilla-central/rev/13397d5e7dcd

Note You need to log in before you can comment on or make changes to this bug.