PGO talos is submitting to the Firefox-Non-PGO tree



Release Engineering
6 years ago
3 years ago


(Reporter: armenzg, Assigned: armenzg)


Firefox Tracking Flags

(Not tracked)



(3 attachments)



6 years ago
This is a fallout from bug 658313.

If we look at this:
we can grab a Windows talos tp log:
we can see that tp5_shutdown_paint posted to Firefox-Non-PGO:[[128,94,496]]

This affects Fedora12, Fedora12x64, Win7 and WinXp.

We have to fix the branch name:
> 'python' '' '-v' '-e' '../firefox/firefox' '-t' 'talos-r3-w7-034' '-b' '1.9.2' '--branchName' 'Firefox-Non-PGO' '--resultsServer' '' '--resultsLink' '/server/collect.cgi' '--activeTests' 'tp5' '--mozAfterPaint' '--symbolsPath' '../symbols'

Comment 1

6 years ago
Created attachment 566268 [details] [diff] [review]
PGO builds should post to $branch rather than $branch-Non-PGO
Assignee: nobody → armenzg
Attachment #566268 - Flags: review?(jhford)
Comment on attachment 566268 [details] [diff] [review]
PGO builds should post to $branch rather than $branch-Non-PGO

We should be looking at branchConfig['add_pgo_builders'] instead.  I have a patch that fixes this issue, will post it shortly.
Attachment #566268 - Flags: review?(jhford) → review-
Created attachment 566310 [details] [diff] [review]
another idea

Before removing my printf debugging lines, some sample output.  MozillaTest is the talos branch we use for all staging test runs.

Rev3 WINNT 5.1 mozilla-1.9.2 talos tp4 - MozillaTest
Rev3 WINNT 5.1 mozilla-inbound talos tp - MozillaTest-Non-PGO
Rev3 WINNT 5.1 mozilla-inbound pgo talos tp - MozillaTest
Rev3 WINNT 5.1 build-system talos tp - MozillaTest
Attachment #566310 - Flags: review?(armenzg)

Comment 4

6 years ago
Comment on attachment 566310 [details] [diff] [review]
another idea

Review of attachment 566310 [details] [diff] [review]:

This is good. I was already trying this same approach but I was not being able to make the output match what I wanted. I probably was doing something wrong.

Feel free to land it any time. I can do a reconfig in the morning if it doesn't happen today.
Attachment #566310 - Flags: review?(armenzg) → review+
Ok, i'll land it now.  Thanks for doing the reconfig!
Comment on attachment 566310 [details] [diff] [review]
another idea
Attachment #566310 - Flags: checked-in?
Flags: needs-reconfig?
Masters have been reconfig'd with this change.
Flags: needs-reconfig? → needs-reconfig+

Comment 8

6 years ago
This hasn't worked:
| Rev3 Fedora 12 mozilla-central pgo talos tp on 2011-10-12 04:02:57 PDT for push e0ae39a3298e
| python -v -e ../firefox/firefox-bin -t talos-r3-fed-009 -b 1.9.2 --branchName Firefox-Non-PGO --resultsServer --resultsLink /server/collect.cgi --activeTests tp5 --mozAfterPaint --symbolsPath ../symbols

Comment 9

6 years ago
Created attachment 566524 [details] [diff] [review]
use pgo_factory
Attachment #566524 - Flags: review?(coop)
Attachment #566524 - Flags: review?(coop) → review+

Comment 10

6 years ago
This is now fixed:[[115,1,1],[115,1,14],[115,1,12],[115,1,15]]&sel=none&displayrange=7&datatype=running
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: → Release Engineering
Attachment #566310 - Flags: checked-in?
You need to log in before you can comment on or make changes to this bug.