Closed Bug 693838 Opened 8 years ago Closed 6 years ago

Convert capitalization of Probes::stuff -> probes::Stuff

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: sfink, Assigned: sankha)

Details

(Whiteboard: [mentor=sfink@mozilla.com][lang=C++])

Attachments

(1 file)

patch v1
24.97 KB, patch
sfink
: review+
Details | Diff | Splinter Review 
Previously, jsprobes.h defined

  class Probes {
    void methodName();
  };

Now it is

  namespace Probes {
  void functionName();
  }

which should be

  namespace probes {
  void FunctionName();
  }
Whiteboard: [mentor=sfink@mozilla.com][lang=C++]
I have not contributed to an open source project before, but I would be interested in working on this bug, could somebody please provide general next steps?
Thanks in advance!
Attached patch patch v1 — — Splinter Review
Assignee: sphink → sankha93
Attachment #816095 - Flags: review?(sphink)
Comment on attachment 816095 [details] [diff] [review]
patch v1

Review of attachment 816095 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thank you!
Attachment #816095 - Flags: review?(sphink) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/44024cc4a59f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.