Closed
Bug 693838
Opened 14 years ago
Closed 12 years ago
Convert capitalization of Probes::stuff -> probes::Stuff
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: sfink, Assigned: sankha)
Details
(Whiteboard: [mentor=sfink@mozilla.com][lang=C++])
Attachments
(1 file)
24.97 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Previously, jsprobes.h defined
class Probes {
void methodName();
};
Now it is
namespace Probes {
void functionName();
}
which should be
namespace probes {
void FunctionName();
}
Reporter | ||
Updated•12 years ago
|
Whiteboard: [mentor=sfink@mozilla.com][lang=C++]
I have not contributed to an open source project before, but I would be interested in working on this bug, could somebody please provide general next steps?
Thanks in advance!
Assignee | ||
Comment 2•12 years ago
|
||
Assignee: sphink → sankha93
Attachment #816095 -
Flags: review?(sphink)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 816095 [details] [diff] [review]
patch v1
Review of attachment 816095 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great, thank you!
Attachment #816095 -
Flags: review?(sphink) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 4•12 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•