693864 - Implement /storage DELETE handling in test JS Sync server

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

One TODO, which is to define the behavior when you submit a non-DELETE request to /storage. I contend that the response should be a 405, and I have included a test for this.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 566451 [details] [diff] [review]
Proposed patch. v1

>   toplevelHandlers: {
>     "storage": function handleStorage(handler, req, resp, version, username, rest) {
>+      let respond = this.respond.bind(this, req, resp);
>+      if (!rest || !rest.length) {
>+        this._log.debug("SyncServer: top-level storage " +
>+                        req.method + " request.");
>+
>+        // TODO: verify if this is spec-compliant.
>+        if (req.method != "DELETE") {
>+          respond(405, "Method Not Allowed", "[]", {"Allow": "DELETE"});
>+          return;
>+        }

Spec is vague about this, but I bet the server does a 404. I do agree that 405 would be better. Follow up with a spec clarification bug?

>   s.start(8080, function () {
>     retrieveWBONotExists(
>-      retrieveWBOExists.bind(this, function () {
>-        s.stop(run_next_test);
>-      })
>-    );
>+      retrieveWBOExists.bind(this,
>+        getStorageFails.bind(this,
>+          deleteStorage.bind(this, function () {
>+            s.stop(run_next_test);
>+          }))));
>   });

Callback-tastic.

Comment 3

[Richard Newman [:rnewman]]

See Bug 694129 for the 405 issue.

Comment 4

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/services/services-central/rev/2c9b36620889

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/2c9b36620889