693907 - Move JS_CallOnce to jsapi.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

Currently it is in jslock.cpp alongside all the other low-level synchronization functionality. But it's the only JSAPI function defined there, and nothing else requires jsapi.h, so it seems like it would be more at home in jsapi.cpp.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Once Upon a JSAPI

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Once Upon a JSAPI

As long as I'm moving it, perhaps I should make it work, too -- I had the success/failure sdrawkcab.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 568197 [details] [diff] [review]
Once Upon a JSAPI

Review of attachment 568197 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +6280,5 @@
>  }
>  
>  #endif
> +
> +#ifdef JS_THREADSAFE

I think I would prefer if you had two threadsafe #ifdef blocks here: one around CallOnce, and another within the body of JS_CallOnce, splitting for the two different implementations.  This would avoid having to repeat the JS_CallOnce signature stuff, which right now is effectively just copy-paste.

Comment 4

[Steve Fink [:sfink] [:s:]]

I think I agree. Thanks.

Comment 5

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f12386561999

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f12386561999