Last Comment Bug 693949 - Drop nsCStringArray
: Drop nsCStringArray
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Mark Banner (:standard8, afk until Dec)
:
: Nathan Froyd [:froydnj]
Mentors:
Depends on: 693946
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-12 02:21 PDT by Mark Banner (:standard8, afk until Dec)
Modified: 2011-10-28 12:19 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
The fix (13.54 KB, patch)
2011-10-23 10:57 PDT, Mark Banner (:standard8, afk until Dec)
benjamin: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8, afk until Dec) 2011-10-12 02:21:51 PDT
Bug 693946 will remove the last uses of nsCStringArray from the code base, as soon as that lands we can just drop nsCStringArray completely:

http://mxr.mozilla.org/comm-central/search?string=nsCStringArray

I'm just confirming the patch I've done works and will post it in a bit.
Comment 1 Mark Banner (:standard8, afk until Dec) 2011-10-23 10:57:53 PDT
Created attachment 568960 [details] [diff] [review]
The fix

This removes the now redundant nsCStringArray. I've taken the opportunity to do some header include cleanup which we'd need to do when we get around to removing nsVoidArray completely.

This passes on try server, and I'll do another check before landing it.
Comment 2 Benjamin Smedberg [:bsmedberg] 2011-10-26 09:45:43 PDT
Comment on attachment 568960 [details] [diff] [review]
The fix

gogogo!
Comment 3 Mark Banner (:standard8, afk until Dec) 2011-10-28 00:47:02 PDT
Checked in: https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf252e6ce4a
Comment 4 Matt Brubeck (:mbrubeck) 2011-10-28 12:19:47 PDT
https://hg.mozilla.org/mozilla-central/rev/fcf252e6ce4a

Note You need to log in before you can comment on or make changes to this bug.