The default bug view has changed. See this FAQ.

xptcinvoke_gcc_x86_unix.cpp fails to compile on mingw

RESOLVED FIXED in mozilla10

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla10
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 566527 [details] [diff] [review]
fix v1.0

It got broken by a commit from bug 684659. Before the breakage, there was a hack to set dllexport attribute for NS_InvokeByIndex_P by having C++ wrapper around an assembly function. For that to work, the assembly version had to be called _NS_InvokeByIndex_P. After the change, the assembly function's name is NS_InvokeByIndex_P on mingw, so there is a linker collision.

My proposed fix adds dllexport equivalent directly in assembly (by adding .drectve section). This way we may get rid of the C++ wrapper.
Attachment #566527 - Flags: review?(benjamin)
Attachment #566527 - Flags: review?(benjamin) → review+
(Assignee)

Comment 1

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bf983d260c6
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/0bf983d260c6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.