Closed Bug 694008 Opened 8 years ago Closed 8 years ago

xptcinvoke_gcc_x86_unix.cpp fails to compile on mingw

Categories

(Core :: XPCOM, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: jacek, Assigned: jacek)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
It got broken by a commit from bug 684659. Before the breakage, there was a hack to set dllexport attribute for NS_InvokeByIndex_P by having C++ wrapper around an assembly function. For that to work, the assembly version had to be called _NS_InvokeByIndex_P. After the change, the assembly function's name is NS_InvokeByIndex_P on mingw, so there is a linker collision.

My proposed fix adds dllexport equivalent directly in assembly (by adding .drectve section). This way we may get rid of the C++ wrapper.
Attachment #566527 - Flags: review?(benjamin)
Attachment #566527 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/0bf983d260c6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.