694014 - Add telemetry for paint time

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

We probably don't want to record all of the paint times, because short paint times will dominate. Perhaps we should only record the times above 16ms.

Comment 1

[(dormant account)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> We probably don't want to record all of the paint times, because short paint
> times will dominate. Perhaps we should only record the times above 16ms.

i think we should record all paints. it's good to get a complete distribution. If you skip 0s then it's hard to track improvements.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Record paint times

I'm not thrilled about the overhead of measuring timestamps on every paint. TimeStamp::Now() is pretty slow on Windows.

Comment 3

[(dormant account)]

Comment on attachment 605070 [details] [diff] [review]
Record paint times

You could condition it on Telemetry::CanRecord().

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 605070 [details] [diff] [review]
Record paint times

You might want to either skip or have a separate category for paints of non-top level windows (nsIWidget::GetWindowType), so that painting relatively simple popups widgets (tool tips, drop downs and other things) doesn't cause the data to be more confusing than it needs to be.

Comment 5

[(dormant account)]

Is this bug going to come back to life soon?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

(In reply to Taras Glek (:taras) from comment #5)
> Is this bug going to come back to life soon?

I don't have any immediate plans. How important do you think this is?

Comment 7

[(dormant account)]

if we ever need to compare perf for gfx improvements(ie see if azure is a win), something like this is required.

Comment 8

[Gregory Pappas [:gregp]]

Bob, I think this exists now: https://probes.telemetry.mozilla.org/?search=paint

Do you think its safe to close this bug?

Comment 9

[Bob Hood [:bhood]]

Yes.