Add telemetry for paint time

NEW
Unassigned

Status

()

Core
Graphics
7 years ago
3 years ago

People

(Reporter: jrmuizel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Snappy:P1])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
We probably don't want to record all of the paint times, because short paint times will dominate. Perhaps we should only record the times above 16ms.

Comment 1

7 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> We probably don't want to record all of the paint times, because short paint
> times will dominate. Perhaps we should only record the times above 16ms.

i think we should record all paints. it's good to get a complete distribution. If you skip 0s then it's hard to track improvements.
Whiteboard: [Snappy:P1]
(Reporter)

Comment 2

6 years ago
Created attachment 605070 [details] [diff] [review]
Record paint times

I'm not thrilled about the overhead of measuring timestamps on every paint. TimeStamp::Now() is pretty slow on Windows.

Comment 3

6 years ago
Comment on attachment 605070 [details] [diff] [review]
Record paint times

You could condition it on Telemetry::CanRecord().
Comment on attachment 605070 [details] [diff] [review]
Record paint times

You might want to either skip or have a separate category for paints of non-top level windows (nsIWidget::GetWindowType), so that painting relatively simple popups widgets (tool tips, drop downs and other things) doesn't cause the data to be more confusing than it needs to be.

Comment 5

6 years ago
Is this bug going to come back to life soon?
(Reporter)

Comment 6

6 years ago
(In reply to Taras Glek (:taras) from comment #5)
> Is this bug going to come back to life soon?

I don't have any immediate plans. How important do you think this is?

Comment 7

6 years ago
if we ever need to compare perf for gfx improvements(ie see if azure is a win), something like this is required.
You need to log in before you can comment on or make changes to this bug.