694193 - design for list that's filtered by tag

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Crystal Beasley [:skinny, :crystal]]

Attachment: screenshot

A list that's filtered by tags should share the tag css from the sidebar of forum posts.

Currently, the tags are links which take you to a list that's filtered to that tag. Desired, delete the tag.

On hover, the X becomes red, borrowing from the sidebar css and the background changes to pink (#FCEBEB). The entire tag button area should be clickable.

Comment 1

[Crystal Beasley [:skinny, :crystal]]

Attachment: delete tag hover

Comment 2

[James Socol [:jsocol, :james]]

You only want to make this change in the top spot (list of active tag filters), right?

Comment 3

[Crystal Beasley [:skinny, :crystal]]

James - where else is filter by tag used in this way?

Comment 4

[:ibai]

Could we "simplify" the bug and make the behavior equivalent? Including a box where you can add tags to the filter? At the moment that's not possible.

Comment 5

[James Socol [:jsocol, :james]]

(In reply to Ibai from comment #4)
> Could we "simplify" the bug and make the behavior equivalent?

Sorry, can you explain that?

> Including a
> box where you can add tags to the filter? At the moment that's not possible.

That's true but probably a separate issue.

(In reply to Crystal Beasley [:skinny, :crystal] from comment #3)
> James - where else is filter by tag used in this way?

The tag adding/removing UI for contributors (with permission, let me know if you need permission on a staging server). It's not "filter by tag" but it's managing adding and removing them from an list.

Comment 6

[:ibai]

My proposal is to make the behavior of the "tags" in the "Filter by tag" feature exactly the same way as what you describe in the answer to Crystal: the adding and removing UI for contributors.

What we are discussing here it's only how we are removing tags, maybe I'm missing the part where we are discussing how to add tags to the "Filter by tag" feature.

Comment 7

[Verdi [:verdi] Best to slack me]

Ibai is right. As someone answering questions in the forum, you need to be able to see the list of all tags and then be able to select the ones you want to filter the questions by (e.g. mac, Firefox 7.0.1). Otherwise you're still left with hacking the url.

Comment 8

[James Socol [:jsocol, :james]]

(In reply to Verdi from comment #7)
> Ibai is right. As someone answering questions in the forum, you need to be
> able to see the list of all tags and then be able to select the ones you
> want to filter the questions by (e.g. mac, Firefox 7.0.1).

Let's tackle that in a different bug and just deal with comment 0 here.

Comment 9

[Crystal Beasley [:skinny, :crystal]]

https://bugzilla.mozilla.org/show_bug.cgi?id=694363 now has a link to the prototype I just made for adding tags

Comment 10

[Verdi [:verdi] Best to slack me]

(In reply to Crystal Beasley [:skinny, :crystal] from comment #9)
> https://bugzilla.mozilla.org/show_bug.cgi?id=694363 now has a link to the
> prototype I just made for adding tags

Thanks Crystal! These two together will be great.

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

https://github.com/jsocol/kitsune/commit/3440307bcb2842511fdaef008ebc2d1bbafd1423

Comment 12

[:ibai]

Thanks Ricky!

You guys rock!

Comment 13

[Rebecca Billings [:rbillings]]

Verified able to filter questions by tag.