Closed Bug 694213 Opened 8 years ago Closed 8 years ago
Display Item::Get Bounds implementations always return an area in our coordinate space
Quite a few of the implementations of GetBounds are returning GetVisualOverflowArea, which is in our parents coordinate space if we are transformed. We should be instead using GetVisualOverflowAreaRelativeToSelf(). This caused bug 692698, and may cause other bugs. It may not be possible for all of these frame types to have transforms, but it's probably good to be consistent.
I did an audit. This should be all instances of this mistake.
Assignee: nobody → tnikkel
Attachment #566709 - Flags: review?(roc)
Attachment #566709 - Flags: review?(roc) → review+
Backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/64fb1f1154f6 there was a talos a11y mozafterpaint regression mail. Not sure if its real or this is at fault, but I backed out anyway.
Pushed to inbound again https://hg.mozilla.org/integration/mozilla-inbound/rev/18f70ede04b0
There was a talos regression mail for a different suite (Talos Regression :( Dromaeo (DOM) decrease 2.56% on XP Mozilla-Inbound-Non-PGO) so I backed out again https://hg.mozilla.org/integration/mozilla-inbound/rev/095174dc1a95 My feeling is that it is probably not real, I'll try landing again later.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.