Make nsDisplayItem::GetBounds implementations always return an area in our coordinate space

RESOLVED FIXED in mozilla10

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mattwoodrow, Assigned: tnikkel)

Tracking

unspecified
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Quite a few of the implementations of GetBounds are returning GetVisualOverflowArea, which is in our parents coordinate space if we are transformed.

We should be instead using GetVisualOverflowAreaRelativeToSelf().

This caused bug 692698, and may cause other bugs. It may not be possible for all of these frame types to have transforms, but it's probably good to be consistent.
(Assignee)

Comment 1

6 years ago
Created attachment 566709 [details] [diff] [review]
patch

I did an audit. This should be all instances of this mistake.
Assignee: nobody → tnikkel
Attachment #566709 - Flags: review?(roc)
Attachment #566709 - Flags: review?(roc) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8db8c9ce92c5
(Assignee)

Comment 3

6 years ago
Backed out
https://hg.mozilla.org/integration/mozilla-inbound/rev/64fb1f1154f6
there was a talos a11y mozafterpaint regression mail. Not sure if its real or this is at fault, but I backed out anyway.
(Assignee)

Comment 4

6 years ago
Pushed to inbound again
https://hg.mozilla.org/integration/mozilla-inbound/rev/18f70ede04b0
(Assignee)

Comment 5

6 years ago
There was a talos regression mail for a different suite (Talos Regression :( Dromaeo (DOM) decrease 2.56% on XP Mozilla-Inbound-Non-PGO) so I backed out again
https://hg.mozilla.org/integration/mozilla-inbound/rev/095174dc1a95
My feeling is that it is probably not real, I'll try landing again later.
(Assignee)

Comment 6

6 years ago
Relanded
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a2c466a8cf
https://hg.mozilla.org/mozilla-central/rev/b4a2c466a8cf
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.