694213 - Make nsDisplayItem::GetBounds implementations always return an area in our coordinate space

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Quite a few of the implementations of GetBounds are returning GetVisualOverflowArea, which is in our parents coordinate space if we are transformed.

We should be instead using GetVisualOverflowAreaRelativeToSelf().

This caused bug 692698, and may cause other bugs. It may not be possible for all of these frame types to have transforms, but it's probably good to be consistent.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

I did an audit. This should be all instances of this mistake.

Comment 2

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8db8c9ce92c5

Comment 3

[Timothy Nikkel (:tnikkel)]

Backed out
https://hg.mozilla.org/integration/mozilla-inbound/rev/64fb1f1154f6
there was a talos a11y mozafterpaint regression mail. Not sure if its real or this is at fault, but I backed out anyway.

Comment 4

[Timothy Nikkel (:tnikkel)]

Pushed to inbound again
https://hg.mozilla.org/integration/mozilla-inbound/rev/18f70ede04b0

Comment 5

[Timothy Nikkel (:tnikkel)]

There was a talos regression mail for a different suite (Talos Regression :( Dromaeo (DOM) decrease 2.56% on XP Mozilla-Inbound-Non-PGO) so I backed out again
https://hg.mozilla.org/integration/mozilla-inbound/rev/095174dc1a95
My feeling is that it is probably not real, I'll try landing again later.

Comment 6

[Timothy Nikkel (:tnikkel)]

Relanded
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a2c466a8cf

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b4a2c466a8cf