Closed Bug 694227 Opened 8 years ago Closed 8 years ago

nsIBaseWindow::blurSuppression is not used

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: enndeakin, Assigned: enndeakin)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Let's remove it.
Attachment #566720 - Flags: review?(benjamin)
Comment on attachment 566720 [details] [diff] [review]
patch

LGTM, although I wonder whether we should actually be doing something with this flag. Did you grep addons to see whether anyone else is using it?
Attachment #566720 - Flags: superreview?(bzbarsky)
Attachment #566720 - Flags: review?(benjamin)
Attachment #566720 - Flags: review+
Comment on attachment 566720 [details] [diff] [review]
patch

r=me
Attachment #566720 - Flags: superreview?(bzbarsky) → superreview+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> Comment on attachment 566720 [details] [diff] [review] [diff] [details] [review]
> patch
> 
> LGTM, although I wonder whether we should actually be doing something with
> this flag. Did you grep addons to see whether anyone else is using it?

It was used as a fix for a crash bug where modal dialogs were opened and the main window closed while blurred. I can't reproduce it any more.
https://hg.mozilla.org/mozilla-central/rev/697558811978
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.